Auth plugins

Auth plugins

[ThomasJWaldmann, 2012-08-19 16:19:30]

http://codereview.appspot.com/6459104/diff/1/MoinMoin/app.py
File MoinMoin/app.py (right):

http://codereview.appspot.com/6459104/diff/1/MoinMoin/app.py#newcode129
MoinMoin/app.py:129: raise error.ConfigurationError("Auth method names must be
unique.")
maybe merge both checks and say "...have a unique name."

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py
File MoinMoin/auth/__init__.py (right):

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:262: class MoinLoginFormAuth(AuthBase):
is this the same as used to be known as MoinAuth?

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:263: name = u"Moin basic auth plugin"
be careful, "basic auth" is misleading as it triggers associations with "http
basic auth".

iirc, in moin 1.9 this was MoinAuth.

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:265: description = u"moin2's builtin auth which
handles login from login form"
maybe do not refer to version numbers from here. thus not "moin2", but just
"moin" or "MoinMoin".

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:275: # the package will most likely contain a single
auth plugin.
check / improve grammar.

[Maiku Mori, 2012-08-19 16:30:33]

http://codereview.appspot.com/6459104/diff/1/MoinMoin/app.py
File MoinMoin/app.py (right):

http://codereview.appspot.com/6459104/diff/1/MoinMoin/app.py#newcode129
MoinMoin/app.py:129: raise error.ConfigurationError("Auth method names must be
unique.")
On 2012/08/19 16:19:30, ThomasJWaldmann wrote:
> maybe merge both checks and say "...have a unique name."

Done.

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py
File MoinMoin/auth/__init__.py (right):

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:262: class MoinLoginFormAuth(AuthBase):
On 2012/08/19 16:19:30, ThomasJWaldmann wrote:
> is this the same as used to be known as MoinAuth?
Yeah it's a wrapper around that class until we can have deeper plugin
integration (requires a lot more refactoring).

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:263: name = u"Moin basic auth plugin"
On 2012/08/19 16:19:30, ThomasJWaldmann wrote:
> be careful, "basic auth" is misleading as it triggers associations with "http
> basic auth".
> 
> iirc, in moin 1.9 this was MoinAuth.

Done.

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:265: description = u"moin2's builtin auth which
handles login from login form"
On 2012/08/19 16:19:30, ThomasJWaldmann wrote:
> maybe do not refer to version numbers from here. thus not "moin2", but just
> "moin" or "MoinMoin".

Done.

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:275: # the package will most likely contain a single
auth plugin.
On 2012/08/19 16:19:30, ThomasJWaldmann wrote:
> check / improve grammar.
Is this better:

        # Plugin config is stored in a key/value dictionary where each key is
plugin's package name.
        # Since package names for inbuilt plugins is "MoinMoin" we need to
somehow refer to specific plugins
        # (as there can be multiple auth plugins, each with seperate config).
        # Auth config is stored under key "auth" and contains a key/value
dictionary where each key is
        # Auth plugin's name. In this case it's "MoinLoginFormAuth".
        # For standalone auth plugin packages this should be a lot more straight
forward since
        # the packages will most likely contain a single auth plugin.

[ThomasJWaldmann, 2012-08-19 17:16:10]

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py
File MoinMoin/auth/__init__.py (right):

http://codereview.appspot.com/6459104/diff/1/MoinMoin/auth/__init__.py#newcod...
MoinMoin/auth/__init__.py:275: # the package will most likely contain a single
auth plugin.
> Is this better:

a bit, see below.
 
>         # Plugin config is stored in a key/value dictionary where each key is
> plugin's package name.

the plugin's

>         # Since package names for inbuilt plugins is "MoinMoin" we need to

name...is or names...are

> somehow refer to specific plugins
>         # (as there can be multiple auth plugins, each with seperate config).
>         # Auth config is stored under key "auth" and contains a key/value
> dictionary where each key is
>         # Auth plugin's name. In this case it's "MoinLoginFormAuth".
>         # For standalone auth plugin packages this should be a lot more
straight
> forward since
>         # the packages will most likely contain a single auth plugin.

OK.