Issue 6459051: code review 6459051: runtime: remove unnecessary ROUND in alg.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6459051: code review 6459051: runtime: remove unnecessary ROUND in alg.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by minux1

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, nigeltao, dave_cheney.net

Visibility:
Public.

Description

runtime: remove unnecessary ROUND in alg.c Introduced in CL 6452046.

Patch Set 2 : diff -r 175e8ad74055 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 175e8ad74055 https://code.google.com/p/go/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/alg.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 9 months ago (2012-08-07 01:46:12 UTC) #1

minux1

Related Russ's comment: http://codereview.appspot.com/6452046/#msg20

12 years, 9 months ago (2012-08-07 01:49:21 UTC) #3

dave_cheney.net

http://codereview.appspot.com/6459051/diff/2001/src/pkg/runtime/alg.c File src/pkg/runtime/alg.c (right): http://codereview.appspot.com/6459051/diff/2001/src/pkg/runtime/alg.c#newcode480 src/pkg/runtime/alg.c:480: ret = (uintptr)(y + t->size); This looks a bit ...

12 years, 9 months ago (2012-08-07 01:49:31 UTC) #4

minux1

*** Submitted as http://code.google.com/p/go/source/detail?r=4bd268b3c88a *** runtime: remove unnecessary ROUND in alg.c Introduced in CL 6452046. ...

12 years, 9 months ago (2012-08-07 01:50:05 UTC) #5

minux1

12 years, 9 months ago (2012-08-07 01:52:17 UTC) #6

On 2012/08/07 01:49:31, dfc wrote:
http://codereview.appspot.com/6459051/diff/2001/src/pkg/runtime/alg.c#newcode480
> src/pkg/runtime/alg.c:480: ret = (uintptr)(y + t->size);
> This looks a bit odd, in essence ret is
>    ret = (unitptr)(x + t->size + t->size);
yes, but we need y anyway, and i try to preserve the original code's structure.

Expand All Messages | Collapse All Messages