Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3570)

Issue 6458110: Some more attributes in particle info node (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by lukas.toenne1
Modified:
11 years, 8 months ago
Reviewers:
brechtvl, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Added a bunch of additional particle state attributes to the Cycles particle info node: * Location: Basically the same as the location from Object Info node for object instances on particles, but in principle there could be additional offsets for dupli objects, so included for completeness. * Size: Single float scale of the particle. Also directly translates to object scale for current dupli objects, but handy to have as a single float to start with instead of a scale vector (currently not even exposed in Object Info). * Rotation: This is a quaternion, which are not yet supported by Cycles nodes. The float4 is copied to internal Cycles data and stored in the particles texture data, but the node doesn't have a socket for it yet and the data is not yet written to the stack. Code is just commented out so could be enabled quickly if/when rotation support is added to cycles. * Velocity: Linear velocity vector of particles. * Angular Velocity: Angular velocity around principle axes. The texture data is currently packed tightly into the particles texture, which saves a few bytes, but requires an additional texture lookup for some vector attributes which spread over two float4s. Could also add another float4 to particle size to avoid this.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -14 lines) Patch
intern/cycles/blender/blender_particles.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
intern/cycles/blender/blender_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
intern/cycles/kernel/kernel_object.h View 1 chunk +40 lines, -3 lines 0 comments Download
intern/cycles/kernel/kernel_types.h View 1 chunk +1 line, -1 line 0 comments Download
intern/cycles/kernel/svm/svm_geometry.h View 1 chunk +30 lines, -8 lines 0 comments Download
intern/cycles/kernel/svm/svm_types.h View 1 chunk +6 lines, -1 line 0 comments Download
intern/cycles/render/nodes.cpp View 3 chunks +51 lines, -0 lines 0 comments Download
intern/cycles/render/object.h View 1 chunk +5 lines, -0 lines 0 comments Download
intern/cycles/render/object.cpp View 1 chunk +5 lines, -1 line 0 comments Download
source/blender/nodes/shader/nodes/node_shader_particle_info.c View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2
lukas.toenne1
11 years, 9 months ago (2012-08-10 13:17:27 UTC) #1
brechtvl
11 years, 8 months ago (2012-08-31 16:58:34 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b