code review 6458100: src/cmd: Add a repurposed import(4), called `9import', ...

src/cmd: Add a repurposed import(4), called `9import', to the ports.

The code is adapted from Plan 9's import(4); this allows us to speak
that protocol. We don't currently support AAN (in the works) or
TLS/SSL.

Thanks to David for help with the man page, testing, and development.

[akumar, 2012-08-08 20:44:51]

Hello david.ducolombier@gmail.com, rsc@swtch.com,

I'd like you to review this change to
http://code.swtch.com/plan9port/

[0intro, 2012-08-08 21:17:13]

I realize that I forgot to send you a draft of the 9import manual. You might
take a look.

https://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c
File src/cmd/9import.c (right):

https://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode115
src/cmd/9import.c:115: sysfatal("tls and ssl have not yet been implemented",
argv[0]);
sysfatal("%s: tls and ssl have not yet been implemented", argv[0]);

https://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode211
src/cmd/9import.c:211: argc = gettokens(cmd, argv, nelem(argv)-2, " ");
argc = tokenize(cmd, argv, nelem(argv)-2);

[akumar, 2012-08-08 21:18:46]

Baaah, this is just sloppiness on my part. Forgive me.

New changes on the way.


Best,
Akshat

On 8 August 2012 14:17,  <0intro@gmail.com> wrote:
> I realize that I forgot to send you a draft of the 9import manual. You
> might take a look.
>
>
> https://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c
> File src/cmd/9import.c (right):
>
> https://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode115
> src/cmd/9import.c:115: sysfatal("tls and ssl have not yet been
> implemented", argv[0]);
> sysfatal("%s: tls and ssl have not yet been implemented", argv[0]);
>
> https://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode211
> src/cmd/9import.c:211: argc = gettokens(cmd, argv, nelem(argv)-2, " ");
> argc = tokenize(cmd, argv, nelem(argv)-2);
>
> https://codereview.appspot.com/6458100/

[akumar, 2012-08-08 22:24:46]

Hello rsc@swtch.com, 0intro@gmail.com,

Please take another look.

[akumar, 2012-08-10 15:14:54]

Added man-page. Gave due credit to David.

PTAL.

http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c
File src/cmd/9import.c (right):

http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode115
src/cmd/9import.c:115: sysfatal("tls and ssl have not yet been implemented",
argv[0]);
On 2012/08/08 21:17:13, 0intro wrote:
> sysfatal("%s: tls and ssl have not yet been implemented", argv[0]);

Done.

http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode211
src/cmd/9import.c:211: argc = gettokens(cmd, argv, nelem(argv)-2, " ");
On 2012/08/08 21:17:13, 0intro wrote:
> argc = tokenize(cmd, argv, nelem(argv)-2);

Done.

[akumar, 2012-08-29 23:56:50]

ping

On 2012/08/10 15:14:54, akumar wrote:
> Added man-page. Gave due credit to David.
> 
> PTAL.
> 
> http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c
> File src/cmd/9import.c (right):
> 
> http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode115
> src/cmd/9import.c:115: sysfatal("tls and ssl have not yet been implemented",
> argv[0]);
> On 2012/08/08 21:17:13, 0intro wrote:
> > sysfatal("%s: tls and ssl have not yet been implemented", argv[0]);
> 
> Done.
> 
> http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode211
> src/cmd/9import.c:211: argc = gettokens(cmd, argv, nelem(argv)-2, " ");
> On 2012/08/08 21:17:13, 0intro wrote:
> > argc = tokenize(cmd, argv, nelem(argv)-2);
> 
> Done.

[akumar, 2012-09-15 19:20:28]

Ping once more?

On 2012/08/29 23:56:50, akumar wrote:
> ping
> 
> On 2012/08/10 15:14:54, akumar wrote:
> > Added man-page. Gave due credit to David.
> > 
> > PTAL.
> > 
> > http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c
> > File src/cmd/9import.c (right):
> > 
> > http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode115
> > src/cmd/9import.c:115: sysfatal("tls and ssl have not yet been implemented",
> > argv[0]);
> > On 2012/08/08 21:17:13, 0intro wrote:
> > > sysfatal("%s: tls and ssl have not yet been implemented", argv[0]);
> > 
> > Done.
> > 
> > http://codereview.appspot.com/6458100/diff/4001/src/cmd/9import.c#newcode211
> > src/cmd/9import.c:211: argc = gettokens(cmd, argv, nelem(argv)-2, " ");
> > On 2012/08/08 21:17:13, 0intro wrote:
> > > argc = tokenize(cmd, argv, nelem(argv)-2);
> > 
> > Done.

[rsc, 2012-09-17 18:29:51]

I can't decide about this. There's already a different 'import'
command, and I've avoided using the 9 prefix. I also don't really
understand how generally useful this is.

Russ

[akumar, 2012-09-19 11:00:16]

My particular use case has been to provide
services to Unix/OS X users, locked in a
namespace created on-the-fly. I personally
find the bits of the import protocol, not found
in the srv protocol, that give exportfs its full
functionality, to be pretty useful.

On 17 September 2012 11:29, Russ Cox <rsc@golang.org> wrote:
> I can't decide about this. There's already a different 'import'
> command, and I've avoided using the 9 prefix. I also don't really
> understand how generally useful this is.
>
> Russ

[rsc, 2012-09-24 14:33:46]

LGTM

[rsc, 2012-09-24 14:35:39]

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=6076381b2991
***

src/cmd: Add a repurposed import(4), called `9import', to the ports.

The code is adapted from Plan 9's import(4); this allows us to speak
that protocol. We don't currently support AAN (in the works) or
TLS/SSL.

Thanks to David for help with the man page, testing, and development.

R=0intro, rsc
CC=plan9port.codebot
http://codereview.appspot.com/6458100

Committer: Russ Cox <rsc@swtch.com>