Issue 6458044: code review 6458044: misc/dashboard/codereview: interpret zero reviewers as ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6458044: code review 6458044: misc/dashboard/codereview: interpret zero reviewers as ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by dsymonds

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

misc/dashboard/codereview: interpret zero reviewers as the CL being closed. This is the state when the CL has been submitted by someone other than the CL author, but before the CL author has synched their client.

Patch Set 1 #

Patch Set 2 : diff -r f6ded2f77aa7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f6ded2f77aa7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 98788e8973f2 https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	misc/dashboard/codereview/dashboard/cl.go	View	1 2	2 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-07-30 03:18:49 UTC) #1

dsymonds

12 years, 11 months ago (2012-07-30 03:51:28 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4883e9e65536 ***

misc/dashboard/codereview: interpret zero reviewers as the CL being closed.

This is the state when the CL has been submitted by someone other than
the CL author, but before the CL author has synched their client.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6458044

Expand All Messages | Collapse All Messages