Try to implement MyDateTime

Try to implement MyDateTime

[ThomasJWaldmann, 2012-08-06 17:50:21]

http://codereview.appspot.com/6457083/diff/1/MoinMoin/forms.py
File MoinMoin/forms.py (right):

http://codereview.appspot.com/6457083/diff/1/MoinMoin/forms.py#newcode102
MoinMoin/forms.py:102: A DateTime that uses timestamp instead of datetime as
internal
if you mean a UNIX timestamp, then say so, otherwise it is unclear.

http://codereview.appspot.com/6457083/diff/1/MoinMoin/forms.py#newcode114
MoinMoin/forms.py:114: if isinstance(value, int):
if it is NOT an int, what else is it here?

[Reimar Bauer, 2012-08-06 20:05:26]

a question

http://codereview.appspot.com/6457083/diff/8001/MoinMoin/forms.py
File MoinMoin/forms.py (right):

http://codereview.appspot.com/6457083/diff/8001/MoinMoin/forms.py#newcode111
MoinMoin/forms.py:111: pass
I wonder a little bit about that pass only

can this become a recursion?

[spy, 2012-08-06 21:26:53]

answered

http://codereview.appspot.com/6457083/diff/8001/MoinMoin/forms.py
File MoinMoin/forms.py (right):

http://codereview.appspot.com/6457083/diff/8001/MoinMoin/forms.py#newcode111
MoinMoin/forms.py:111: pass
On 2012/08/06 20:05:26, Reimar Bauer wrote:
> I wonder a little bit about that pass only
> 
> can this become a recursion?

hm, do not really understand how this might happen.
If value is an instance of int and it is a correct timestamp (valid range) it is
replaced with datetime.datetime representation of it. Then it works the same way
as DateTime.
If it is an incorrect timestamp, it will not be converted and
super(...).serialize() will return unicode(value).

[Reimar Bauer, 2012-08-07 11:22:44]

some comments

http://codereview.appspot.com/6457083/diff/9003/MoinMoin/_tests/test_forms.py
File MoinMoin/_tests/test_forms.py (right):

http://codereview.appspot.com/6457083/diff/9003/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:34: dt_str = str(dt_u)
what happens with an incorrect time string?

e.g. only date given?

usually the inputs are unicode and not str,
does it need str?

[ThomasJWaldmann, 2012-08-07 15:05:50]

http://codereview.appspot.com/6457083/diff/9003/MoinMoin/_tests/test_forms.py
File MoinMoin/_tests/test_forms.py (right):

http://codereview.appspot.com/6457083/diff/9003/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:27: assert d.u == unicode(incorrect_timestamp)
hmm, is that handled like this in general in flatland?
.value being None, .u being something like the input value?

[spy, 2012-08-07 19:39:48]

answered

http://codereview.appspot.com/6457083/diff/9003/MoinMoin/_tests/test_forms.py
File MoinMoin/_tests/test_forms.py (right):

http://codereview.appspot.com/6457083/diff/9003/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:27: assert d.u == unicode(incorrect_timestamp)
On 2012/08/07 15:05:50, ThomasJWaldmann wrote:
> hmm, is that handled like this in general in flatland?
> .value being None, .u being something like the input value?

Yes, that is well described in the following doc string.
this is a set method of flatland's Scalar element:

def set(self, value):
    """Assign the native and Unicode value.

    :returns: True if adaptation of *value* was successful.

    Attempts to adapt the given value and assigns this element's
    :attr:`~flatland.Element.value` and :attr:`u`
    attributes in tandem.

    If adaptation succeeds, ``.value`` will contain the
    :meth:`adapted<adapt>` native Python value and ``.u`` will contain a
    Unicode :meth:`serialized<serialize>` version of it.  A native value
    of ``None`` will be represented as ``u''`` in ``.u``.

    If adaptation fails, ``.value`` will be ``None`` and ``.u`` will
    contain ``unicode(value)`` or ``u''`` for none.

    """

http://codereview.appspot.com/6457083/diff/9003/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:34: dt_str = str(dt_u)
On 2012/08/07 11:22:44, Reimar Bauer wrote:
> what happens with an incorrect time string?
> 
> e.g. only date given?

In this case adaptation fails. Native value will be None and .u will contain an
incorrect time string.

> usually the inputs are unicode and not str,
> does it need str?

uh, I thought they are string, no it doesn't.

[Reimar Bauer, 2012-08-07 19:59:21]

only small comments

http://codereview.appspot.com/6457083/diff/4006/MoinMoin/_tests/test_forms.py
File MoinMoin/_tests/test_forms.py (right):

http://codereview.appspot.com/6457083/diff/4006/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:9: 
import pytest not needed or?

http://codereview.appspot.com/6457083/diff/4006/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:38: incorrect_string = u'2012-10-30'
incorrect_timestring

because you also name incorrect_timestamp

[spy, 2012-08-07 20:13:19]

http://codereview.appspot.com/6457083/diff/4006/MoinMoin/_tests/test_forms.py
File MoinMoin/_tests/test_forms.py (right):

http://codereview.appspot.com/6457083/diff/4006/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:9: 
On 2012/08/07 19:59:21, Reimar Bauer wrote:
> import pytest not needed or?

removed

http://codereview.appspot.com/6457083/diff/4006/MoinMoin/_tests/test_forms.py...
MoinMoin/_tests/test_forms.py:38: incorrect_string = u'2012-10-30'
On 2012/08/07 19:59:21, Reimar Bauer wrote:
> incorrect_timestring
> 
> because you also name incorrect_timestamp

Done.