code review 6457052: misc/dashboard/codereview: pass user information to gob...

misc/dashboard/codereview: pass user information to gobot when assigning reviewer.

[dsymonds, 2012-07-30 04:38:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gobot, 2012-07-30 04:38:39]

R=rsc (assigned by dsymonds)

[gobot, 2012-07-30 04:39:05]

R=bradfitz (assigned by dsymonds)

[bradfitz, 2012-07-30 04:39:46]

LGTM

On Sun, Jul 29, 2012 at 9:38 PM, <dsymonds@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> misc/dashboard/codereview: pass user information to gobot when assigning
> reviewer.
>
> Please review this at
http://codereview.appspot.com/**6457052/<http://codereview.appspot.com/6457052/>
>
> Affected files:
>   M misc/dashboard/codereview/**dashboard/cl.go
>
>
> Index: misc/dashboard/codereview/**dashboard/cl.go
> ==============================**==============================**=======
> --- a/misc/dashboard/codereview/**dashboard/cl.go
> +++ b/misc/dashboard/codereview/**dashboard/cl.go
> @@ -128,7 +128,8 @@
>         }
>
>         u := user.Current(c)
> -       if _, ok := emailToPerson[u.Email]; !ok {
> +       person, ok := emailToPerson[u.Email]
> +       if !ok {
>                 http.Error(w, "Not allowed", http.StatusUnauthorized)
>                 return
>         }
> @@ -183,7 +184,7 @@
>                 if !found {
>                         c.Infof("Adding %v as a reviewer of CL %v", rev, n)
>
> -                       url := fmt.Sprintf("%s?cl=%s&r=%s", gobotBase, n,
> rev)
> +                       url := fmt.Sprintf("%s?cl=%s&r=%s&**obo=%s",
> gobotBase, n, rev, person)
>                         resp, err := urlfetch.Client(c).Get(url)
>                         if err != nil {
>                                 c.Errorf("Gobot GET failed: %v", err)
>
>
>

[dsymonds, 2012-07-30 04:41:11]

*** Submitted as http://code.google.com/p/go/source/detail?r=15e7c4ad9763 ***

misc/dashboard/codereview: pass user information to gobot when assigning
reviewer.

R=bradfitz
CC=gobot, golang-dev, rsc
http://codereview.appspot.com/6457052