code review 6455055: cmd/gc: fix initialization order involving method calls.

cmd/gc: fix initialization order involving method calls.

They were previously ignored when deciding order and
detecting dependency loops.
Fixes issue 3824.

[remyoudompheng, 2012-07-28 07:52:50]

Hello rsc@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com, remy@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-07-29 23:56:20]

LGTM

http://codereview.appspot.com/6455055/diff/5001/src/cmd/gc/reflect.c
File src/cmd/gc/reflect.c (right):

http://codereview.appspot.com/6455055/diff/5001/src/cmd/gc/reflect.c#newcode135
src/cmd/gc/reflect.c:135: t->nname = f->nname;
// Link to name of original method function.

(and add braces)

http://codereview.appspot.com/6455055/diff/5001/src/cmd/gc/sinit.c
File src/cmd/gc/sinit.c (right):

http://codereview.appspot.com/6455055/diff/5001/src/cmd/gc/sinit.c#newcode39
src/cmd/gc/sinit.c:39: if(n->left && n->type && n->left->op == OTYPE && n->class
== PFUNC)
Since you have multiple lines, even though it's one statement, please add { }
around body.

[remyoudompheng, 2012-07-30 07:04:44]

Hello rsc@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com, remy@archlinux.org),

Please take another look.

[remyoudompheng, 2012-07-30 07:14:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=80c98738fdde ***

cmd/gc: fix initialization order involving method calls.

They were previously ignored when deciding order and
detecting dependency loops.
Fixes issue 3824.

R=rsc, golang-dev
CC=golang-dev, remy
http://codereview.appspot.com/6455055

[remyoudompheng, 2012-07-30 07:15:40]

On 2012/07/30 07:04:44, remyoudompheng wrote:
> Please take another look.

Applied the comments and renamed test file to bug446.go (the other pending
patches use 447 and 448).