Issue 6454174: [http issue 131] Removed deprecated classes/methods/fields from version 1.9 and 1.10

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6454174: [http issue 131] Removed deprecated classes/methods/fields from version 1.9 and 1.10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by yanivi

Modified:
11 years, 8 months ago

Reviewers:
rmistry

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : check #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -273 lines)			Patch
M	google-http-client/src/main/java/com/google/api/client/http/AbstractInputStreamContent.java	View	3 chunks	+5 lines, -9 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/BackOffPolicy.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/BasicAuthentication.java	View	2 chunks	+0 lines, -6 lines	1 comment	Download
M	google-http-client/src/main/java/com/google/api/client/http/ExponentialBackOffPolicy.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpParser.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java	View	6 chunks	+3 lines, -18 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java	View	8 chunks	+14 lines, -28 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java	View	1 chunk	+2 lines, -13 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/LowLevelHttpRequest.java	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java	View	3 chunks	+2 lines, -28 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/UrlEncodedParser.java	View	2 chunks	+1 line, -91 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java	View	11 chunks	+10 lines, -17 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpContent.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpParser.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/xml/XmlHttpParser.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/xml/atom/AtomParser.java	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/Json.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/JsonParser.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpResponse.java	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/xml/atom/Atom.java	View	2 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rmistry

11 years, 8 months ago (2012-08-23 12:51:17 UTC) #2

LGTM

http://codereview.appspot.com/6454174/diff/3001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/BasicAuthentication.java
(left):

http://codereview.appspot.com/6454174/diff/3001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/BasicAuthentication.java:53:
intercept(request);
This may break some tests and will be hard to detect, but not sure what we can
do about that.

Expand All Messages | Collapse All Messages