Issue 6454126: code review 6454126: go.crypto/ssh: cosmetic: move remaining channel code in...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6454126: code review 6454126: go.crypto/ssh: cosmetic: move remaining channel code in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dave

Modified:
11 years, 8 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

go.crypto/ssh: cosmetic: move remaining channel code into channel.go This CL scratches an itch by moving the remaining channel related code into channel.go.

Patch Set 1 #

Patch Set 2 : code review 6454126: go.crypto/ssh: cosmetic: move remaining channel code in... #

Patch Set 3 : diff -r 5140f139859b https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 5140f139859b https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 5140f139859b https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 931b7eb9e594 https://code.google.com/p/go.crypto #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -118 lines)			Patch
	M	ssh/channel.go	View	1 2 3 4	1 chunk	+118 lines, -0 lines	0 comments	Download
	M	ssh/client.go	View	1 2 3	2 chunks	+0 lines, -118 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years, 8 months ago (2012-08-09 23:34:01 UTC) #1

dave_cheney.net

11 years, 8 months ago (2012-08-11 02:19:04 UTC) #3

*** Submitted as
http://code.google.com/p/go/source/detail?r=b40d39ad1699&repo=crypto ***

go.crypto/ssh: cosmetic: move remaining channel code into channel.go

This CL scratches an itch by moving the remaining channel related code
into channel.go.

R=agl
CC=golang-dev
http://codereview.appspot.com/6454126

Expand All Messages | Collapse All Messages