Issue 6453084: code review 6453084: cmd/8g: fix miscompilation due to BADWIDTH.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453084: code review 6453084: cmd/8g: fix miscompilation due to BADWIDTH. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by remyoudompheng

Modified:
12 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev, remy_archlinux.org

Visibility:
Public.

Description

cmd/8g: fix miscompilation due to BADWIDTH. Fixes issue 3899.

Patch Set 1 #

Patch Set 2 : diff -r 32eb6dac3ff4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 32eb6dac3ff4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d68605d10a6b https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	src/cmd/8g/gsubr.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	A	test/fixedbugs/bug450.go	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-08-03 19:11:57 UTC) #1

remyoudompheng

I am quite confused that the very large differences between some parts of 6g and ...

12 years, 9 months ago (2012-08-03 19:14:32 UTC) #2

rsc

LGTM The primary reason for the difference in 8g is that the x86-32 has approximately ...

12 years, 9 months ago (2012-08-03 19:33:32 UTC) #3

remyoudompheng

12 years, 9 months ago (2012-08-03 20:06:04 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=f6a6fe780649 ***

cmd/8g: fix miscompilation due to BADWIDTH.

Fixes issue 3899.

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/6453084

Expand All Messages | Collapse All Messages