Issue 6453045: code review 6453045: testing: allow concurrent use of T and B

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453045: code review 6453045: testing: allow concurrent use of T and B (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bradfitz

Modified:
11 years, 9 months ago

Reviewers:
dvyukov

CC:
golang-dev, r

Visibility:
Public.

Description

testing: allow concurrent use of T and B Notably, allow concurrent logging and failing.

Patch Set 1 #

Patch Set 2 : diff -r 6eb7e61b5286 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 6eb7e61b5286 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 6eb7e61b5286 https://go.googlecode.com/hg #

Patch Set 5 : diff -r 6eb7e61b5286 https://go.googlecode.com/hg #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -7 lines)			Patch
	M	src/pkg/testing/testing.go	View	1 2	7 chunks	+20 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

11 years, 9 months ago (2012-07-25 16:32:45 UTC) #1

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=7a67d277c7e8 *** testing: allow concurrent use of T and B Notably, allow ...

11 years, 9 months ago (2012-07-25 17:17:36 UTC) #3

dvyukov

I think it fixes http://code.google.com/p/go/issues/detail?id=3863 as well.

11 years, 9 months ago (2012-07-25 17:29:25 UTC) #4

bradfitz

11 years, 9 months ago (2012-07-25 17:30:51 UTC) #5

On Wed, Jul 25, 2012 at 10:29 AM, <dvyukov@google.com> wrote:

> I think it fixes
http://code.google.com/p/go/**issues/detail?id=3863<http://code.google.com/p/...
> well.


Is it easy for you to verify?

Expand All Messages | Collapse All Messages