Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 6452072: Doc: Clarify automatic beam setting (2701) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Trevor Daniels
Modified:
11 years, 8 months ago
Reviewers:
Graham Percival, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: Clarify automatic beam setting (2701) Explain at the beginning the precedence of the rules, and include an example to show how to disable beamExceptions.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change headings to use unnumberedsubsubsec as suggested by David. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M Documentation/notation/rhythms.itely View 1 4 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 17
Trevor Daniels
For Graham, really: http://codereview.appspot.com/6452072/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/6452072/diff/1/Documentation/notation/rhythms.itely#newcode2007 Documentation/notation/rhythms.itely:2007: @i{@strong{Beaming based on @code{baseMoment} and @code{beatStructure}}} ...
11 years, 9 months ago (2012-07-31 22:30:12 UTC) #1
Trevor Daniels
In vocal.itely both @subheading and @subsubheading are used. The CG advice is to use @subheading. ...
11 years, 8 months ago (2012-08-02 21:03:15 UTC) #2
Graham Percival
LGTM although I'm not wild about the @i{} bits, I can't immediately think of a ...
11 years, 8 months ago (2012-08-03 09:30:55 UTC) #3
dak
On 2012/08/03 09:30:55, Graham Percival wrote: > LGTM although I'm not wild about the @i{} ...
11 years, 8 months ago (2012-08-03 09:35:47 UTC) #4
Trevor Daniels
On 2012/08/03 09:35:47, dak wrote: > The obvious way would be to reorganize into fewer ...
11 years, 8 months ago (2012-08-04 08:06:38 UTC) #5
dak
On 2012/08/04 08:06:38, Trevor Daniels wrote: > On 2012/08/03 09:35:47, dak wrote: > > > ...
11 years, 8 months ago (2012-08-04 08:27:10 UTC) #6
Trevor Daniels
On 2012/08/04 08:27:10, dak wrote: > But again: the real issue to me seems that ...
11 years, 8 months ago (2012-08-04 09:20:57 UTC) #7
dak
On 2012/08/04 09:20:57, Trevor Daniels wrote: > On 2012/08/04 08:27:10, dak wrote: > > > ...
11 years, 8 months ago (2012-08-04 09:33:33 UTC) #8
Trevor Daniels
On 2012/08/04 09:33:33, dak wrote: > I don't see that ignoring even the proposal to ...
11 years, 8 months ago (2012-08-04 15:11:55 UTC) #9
dak
On 2012/08/04 15:11:55, Trevor Daniels wrote: > On 2012/08/04 09:33:33, dak wrote: > > I'm ...
11 years, 8 months ago (2012-08-04 15:35:44 UTC) #10
Trevor Daniels
OK, I think we've arrived at an acceptable solution, albeit via a somewhat circuitous route, ...
11 years, 8 months ago (2012-08-04 21:42:30 UTC) #11
Trevor Daniels
Pushed to staging as 593d611c5f63f3fedadf299e124a83ca4a709fe6 Leaving open until pdf has been checked
11 years, 8 months ago (2012-08-07 21:19:00 UTC) #12
Trevor Daniels
On 2012/08/07 21:19:00, Trevor Daniels wrote: > Leaving open until pdf has been checked In ...
11 years, 8 months ago (2012-08-08 18:58:08 UTC) #13
dak
On 2012/08/08 18:58:08, Trevor Daniels wrote: > On 2012/08/07 21:19:00, Trevor Daniels wrote: > > ...
11 years, 8 months ago (2012-08-08 19:13:42 UTC) #14
Trevor Daniels
Changed level 5 headings to @subsubheading @i{ .. } and pushed directly to staging as ...
11 years, 8 months ago (2012-08-09 07:36:46 UTC) #15
Trevor Daniels
On 2012/08/09 07:36:46, Trevor Daniels wrote: > Changed level 5 headings to @subsubheading @i{ .. ...
11 years, 8 months ago (2012-08-10 07:54:51 UTC) #16
dak
11 years, 8 months ago (2012-08-10 08:37:51 UTC) #17
On 2012/08/10 07:54:51, Trevor Daniels wrote:
> On 2012/08/09 07:36:46, Trevor Daniels wrote:
> 
> > Changed level 5 headings to @subsubheading @i{ .. }
> 
> These look fine to me in both pdf and html, so I'm
> closing this review.  I'll open a new issue tracker 
> to cover using level 5 headings uniformly.

If we need them semi-regularly, maybe we should invent a name for them and use a
macro?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b