Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 6450165: code review 6450165: net/http: add (*ServeMux).Handler method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by rsc
Modified:
11 years, 8 months ago
Reviewers:
CC:
golang-dev, bradfitzgoog, dsymonds
Visibility:
Public.

Description

net/http: add (*ServeMux).Handler method The Handler method makes the ServeMux dispatch logic available to wrappers that enforce additional constraints on requests.

Patch Set 1 #

Patch Set 2 : diff -r bf1b1141ccbf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c8cc72708080 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c8cc72708080 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -20 lines) Patch
M src/pkg/net/http/server.go View 1 2 5 chunks +38 lines, -20 lines 0 comments Download
A src/pkg/net/http/server_test.go View 1 3 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 8 months ago (2012-08-20 18:55:11 UTC) #1
bradfitzgoog
LGTM The codeSaver exists elsewhere in httptest iirc but no harm. I assume people who ...
11 years, 8 months ago (2012-08-20 22:45:49 UTC) #2
dsymonds
LGTM
11 years, 8 months ago (2012-08-21 01:00:49 UTC) #3
rsc
11 years, 8 months ago (2012-08-31 16:16:36 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=5d4729745797 ***

net/http: add (*ServeMux).Handler method

The Handler method makes the ServeMux dispatch logic
available to wrappers that enforce additional constraints
on requests.

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
http://codereview.appspot.com/6450165
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b