Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 6450058: code review 6450058: os: move epipecheck from file_posix.go and into file_un... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by brainman
Modified:
12 years, 10 months ago
Reviewers:
minux1, r, dvyukov
CC:
golang-dev
Visibility:
Public.

Description

os: move epipecheck from file_posix.go and into file_unix.go to fix windows build

Patch Set 1 #

Patch Set 2 : diff -r 8b3bf65c620c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8b3bf65c620c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8b3bf65c620c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/pkg/os/file_posix.go View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/pkg/os/file_unix.go View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/os/file_windows.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 10 months ago (2012-07-27 12:14:02 UTC) #1
brainman
*** Submitted as http://code.google.com/p/go/source/detail?r=d127749038e8 *** os: move epipecheck from file_posix.go and into file_unix.go to fix ...
12 years, 10 months ago (2012-07-27 12:21:42 UTC) #2
minux1
LGTM.
12 years, 10 months ago (2012-07-27 18:10:00 UTC) #3
dvyukov
LGTM
12 years, 10 months ago (2012-07-28 11:03:31 UTC) #4
r
12 years, 10 months ago (2012-07-28 15:47:05 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b