Issue 6449094: add itemtype metadata to DummyRev

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449094: add itemtype metadata to DummyRev (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by xiaq

Modified:
11 years, 9 months ago

Reviewers:
thomas.j.waldmann, Reimar Bauer

Visibility:
Public.

More Reviews

Description

add itemtype metadata to DummyRev

Patch Set 1 : #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	MoinMoin/items/__init__.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download
	M	MoinMoin/items/_tests/test_Item.py	View		2 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

xiaq

This patch set adds itemtype metadata to DummyRev. As a result, itemtype is now set ...

11 years, 9 months ago (2012-08-06 02:25:53 UTC) #1

ThomasJWaldmann

11 years, 9 months ago (2012-08-09 11:44:27 UTC) #3

http://codereview.appspot.com/6449094/diff/4/MoinMoin/items/_tests/test_Item.py
File MoinMoin/items/_tests/test_Item.py (right):

http://codereview.appspot.com/6449094/diff/4/MoinMoin/items/_tests/test_Item....
MoinMoin/items/_tests/test_Item.py:22: from MoinMoin.constants.keys import
ITEMTYPE
maybe do it all the new way (from constants.keys in general), see the old line
above this one.

Expand All Messages | Collapse All Messages