Issue 6449091: code review 6449091: goprotobuf: Handle XXX_unrecognized correctly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449091: code review 6449091: goprotobuf: Handle XXX_unrecognized correctly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dsymonds

Modified:
13 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Handle XXX_unrecognized correctly. In particular, - add it to marshaled messages - examine it in Clone, Equal

Patch Set 1 #

Patch Set 2 : diff -r 88ccec1be991 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 88ccec1be991 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 88ccec1be991 https://code.google.com/p/goprotobuf #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -7 lines)			Patch
M	proto/all_test.go	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	proto/clone.go	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download
M	proto/clone_test.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	proto/encode.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	proto/equal.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	proto/message_set.go	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	proto/properties.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	proto/testdata/test.proto	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years, 3 months ago (2012-08-04 00:20:54 UTC) #1

LGTM although it could stand a more helpful CL description. this is hardly better than ...

13 years, 3 months ago (2012-08-04 04:04:54 UTC) #2

dsymonds

13 years, 3 months ago (2012-08-04 06:38:14 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=2668bb32ec0e ***

goprotobuf: Handle XXX_unrecognized correctly.

In particular,
  - add it to marshaled messages
  - examine it in Clone, Equal

R=r
CC=golang-dev
http://codereview.appspot.com/6449091

Expand All Messages | Collapse All Messages