[http issue 85] Upgrade to Jackson 2

[benjamin.j.mccann, 2012-08-20 21:08:07]

The .classpath file, .project file, and .settings directory probably should not
be checked into revision control.

[yanivi, 2012-08-20 22:10:29]

On 2012/08/20 21:08:07, benjamin.j.mccann wrote:
> The .classpath file, .project file, and .settings directory probably should
not
> be checked into revision control.

Would you kindly explain why not?  It makes it easier to set up the Eclipse
project with common settings.

[benjamin.j.mccann, 2012-08-20 23:02:19]

I figured you just overlooked those files.  I didn't know you were intentionally
checking them in.  I don't have a real strong reason.  Only suggesting that
because that's what I've seen from other projects I've worked with.

[rmistry, 2012-08-22 12:05:50]

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
File
google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/JacksonFactory.java
(right):

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/JacksonFactory.java:1:
/*
Could you do a hg copy of the files in this directory, I cannot tell what the
changes are.

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
File
google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/package-info.java
(right):

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/package-info.java:17:
* href="http://wiki.fasterxml.com/JacksonHome">Jackson 2</a> JSON library.
Maybe this URL is better? http://wiki.fasterxml.com/JacksonRelease20 (since it
explicitly talks about Jackson2)

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
File
google-http-client-jackson2/src/test/java/com/google/api/client/json/jackson2/JacksonFactoryTest.java
(right):

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
google-http-client-jackson2/src/test/java/com/google/api/client/json/jackson2/JacksonFactoryTest.java:1:
/*
hg copy for this class too please.

[rmistry, 2012-08-22 20:14:35]

LGTM

[yanivi, 2012-08-22 20:15:48]

I'm not comfortable with the hg cp stuff.  FYI there are literally no
implementation differences other than the change in package names.  You're
welcome to do a diff locally to verify that.

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
File
google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/package-info.java
(right):

http://codereview.appspot.com/6448175/diff/1020/google-http-client-jackson2/s...
google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/package-info.java:17:
* href="http://wiki.fasterxml.com/JacksonHome">Jackson 2</a> JSON library.
On 2012/08/22 12:05:50, rmistry wrote:
> Maybe this URL is better? http://wiki.fasterxml.com/JacksonRelease20 (since it
> explicitly talks about Jackson2)

Done.