BlueprintPlugins

BlueprintPlugins

For reference my config file:


from wikiconfig import *

class LocalConfig(Config):
    sitename = u'My MoinMoin Dev Fork'
    acl_functions = u'+MM:superuser TrustedEditorGroup:notextcha'

    example_plugin_config = {
        "default_name": "Jack Sparrow",
    }
    plugins_config = {
        "ExampleMoinPlugin": example_plugin_config,
    }
    plugins_enabled = [
        "ExampleMoinPlugin",
        "MoinMoin.themes.foobar",
        "MoinMoin.themes.modernized",
        "MoinMoin.storage.stores.fs",
    ]
    theme_default = "Modernized"


MOINCFG = LocalConfig
DEBUG = True

[ThomasJWaldmann, 2012-08-06 14:39:35]

http://codereview.appspot.com/6448102/diff/1/MoinMoin/plugin.py
File MoinMoin/plugin.py (right):

http://codereview.appspot.com/6448102/diff/1/MoinMoin/plugin.py#newcode116
MoinMoin/plugin.py:116: """
use a property maybe?

http://codereview.appspot.com/6448102/diff/1/MoinMoin/plugin.py#newcode124
MoinMoin/plugin.py:124: return dict()
use a property maybe?

http://codereview.appspot.com/6448102/diff/1/contrib/ExamplePlugin/ExampleMoi...
File contrib/ExamplePlugin/ExampleMoinPlugin/__init__.py (right):

http://codereview.appspot.com/6448102/diff/1/contrib/ExamplePlugin/ExampleMoi...
contrib/ExamplePlugin/ExampleMoinPlugin/__init__.py:22: self.default_name =
cfg.get("default_name", "Anonymous")
having a configurable user name to greet is likely a bad example as we know the
real user's name via flaskg.user.name.

http://codereview.appspot.com/6448102/diff/1/contrib/ExamplePlugin/ExampleMoi...
contrib/ExamplePlugin/ExampleMoinPlugin/__init__.py:24: self.example =
Blueprint('example', __name__, template_folder='templates')
where exactly is this template folder located?

http://codereview.appspot.com/6448102/diff/1/contrib/ExamplePlugin/ExampleMoi...
contrib/ExamplePlugin/ExampleMoinPlugin/__init__.py:26:
self.example.after_request(teardown_wiki)
as this plugin isn't doing anything wiki-like, it doesn't need these?

http://codereview.appspot.com/6448102/diff/1/contrib/ExamplePlugin/ExampleMoi...
contrib/ExamplePlugin/ExampleMoinPlugin/__init__.py:46: return "Hello,
{0}!".format(name)
do you use some static data (like an image or css) somewhere to show that your
plugin code can deal with that?

[Maiku Mori, 2012-08-13 08:48:54]

http://codereview.appspot.com/6448102/diff/1/MoinMoin/plugin.py
File MoinMoin/plugin.py (right):

http://codereview.appspot.com/6448102/diff/1/MoinMoin/plugin.py#newcode116
MoinMoin/plugin.py:116: """
On 2012/08/06 14:39:35, ThomasJWaldmann wrote:
> use a property maybe?
Isn't method a bit more flexible here? Then again I guess you can do all the
initialization (and set the property) in __init__()

http://codereview.appspot.com/6448102/diff/1/MoinMoin/plugin.py#newcode124
MoinMoin/plugin.py:124: return dict()
On 2012/08/06 14:39:35, ThomasJWaldmann wrote:
> use a property maybe?
Yeah, makes sense.