Issue 6446114: Particle storage in cycles, bugfix #32184

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6446114: Particle storage in cycles, bugfix #32184 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by lukas.toenne1

Modified:
11 years, 8 months ago

Reviewers:
brechtvl, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

This is a bit of redesign made necessary to fix this bug http://projects.blender.org/tracker/index.php?func=detail&aid=32184&group_id=9&atid=498 The particle data used by the Particle Info node was stored in cycles as a list in each object. This is a problem when the particle emitter mesh is hidden: Objects in cycles are only intended as instances of renderable meshes, so when hiding the emitter mesh the particle data doesn't get stored either. Also the particle data can potentially be copied to multiple instances of the same object, which is a waste of texture space. The solution in this patch is to make a completely separate list of particle systems in the Cycles scene data. This way the particle data can be generated even when the emitter object itself is not visible.

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+314 lines, -96 lines)			Patch
intern/cycles/blender/blender_object.cpp	View	2 chunks	+1 line, -8 lines	0 comments	Download
intern/cycles/blender/blender_particles.cpp	View	7 chunks	+82 lines, -37 lines	0 comments	Download
intern/cycles/blender/blender_sync.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
intern/cycles/blender/blender_sync.cpp	View	4 chunks	+9 lines, -0 lines	0 comments	Download
intern/cycles/blender/blender_util.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
intern/cycles/render/CMakeLists.txt	View	2 chunks	+2 lines, -0 lines	0 comments	Download
intern/cycles/render/object.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
intern/cycles/render/object.cpp	View	3 chunks	+0 lines, -40 lines	0 comments	Download
intern/cycles/render/particles.h	View	1 chunk	+69 lines, -0 lines	0 comments	Download
intern/cycles/render/particles.cpp	View	1 chunk	+118 lines, -0 lines	0 comments	Download
intern/cycles/render/scene.h	View	3 chunks	+4 lines, -0 lines	0 comments	Download
intern/cycles/render/scene.cpp	View	5 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sorry for late review, but LGTM, please commit.

Expand All Messages | Collapse All Messages