Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4872)

Issue 6446099: code review 6446099: leveldb: rewrite memfs_test's TestBasics as a table-dri... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by nigeltao
Modified:
12 years, 3 months ago
Reviewers:
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

leveldb: rewrite memfs_test's TestBasics as a table-driven test.

Patch Set 1 #

Patch Set 2 : diff -r 1d5ccbe03246 https://code.google.com/p/leveldb-go #

Patch Set 3 : diff -r 1d5ccbe03246 https://code.google.com/p/leveldb-go #

Total comments: 1

Patch Set 4 : diff -r 1d5ccbe03246 https://code.google.com/p/leveldb-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -149 lines) Patch
M leveldb/memfs/memfs_test.go View 1 2 chunks +122 lines, -149 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/leveldb-go
12 years, 3 months ago (2012-08-08 05:22:59 UTC) #1
dsymonds
LGTM http://codereview.appspot.com/6446099/diff/4001/leveldb/memfs/memfs_test.go File leveldb/memfs/memfs_test.go (right): http://codereview.appspot.com/6446099/diff/4001/leveldb/memfs/memfs_test.go#newcode29 leveldb/memfs/memfs_test.go:29: "1a: create /foo", the "1a", "2a", etc. prefixes ...
12 years, 3 months ago (2012-08-08 05:30:22 UTC) #2
nigeltao
12 years, 3 months ago (2012-08-09 03:46:38 UTC) #3
*** Submitted as
http://code.google.com/p/leveldb-go/source/detail?r=e52508b8dc6d ***

leveldb: rewrite memfs_test's TestBasics as a table-driven test.

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/6446099
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b