code review 6446060: misc/cgo/test: only run setgid test on GNU/Linux

misc/cgo/test: only run setgid test on GNU/Linux

Fixes issue 3874.

[iant, 2012-07-28 06:43:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[nathany, 2012-07-28 07:43:27]

If I also remove the #include <unistd.h> line from basic.go, as prior to
https://code.google.com/p/go/source/detail?r=f0b8f8a81cab85b06d2533e1e5e86c8c...
then it will build fine on Darwin.

[iant, 2012-07-28 14:34:24]

Oh, sorry, I meant to do that, but I forgot.  Fixed.

[iant, 2012-07-28 14:34:37]

Hello golang-dev@googlegroups.com, nj@nathany.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[nathany, 2012-07-28 15:00:45]

On 2012/07/28 14:34:37, iant wrote:
> Please take another look.

I reverted the local changes and ran hg clpatch 6446060. Everything built fine.

I was wondering if removing the #include <unistd.h> line would be enough, but
after testing, I can confirm that moving this test out into linux_test is
necessary (to call setgid).

[r, 2012-07-28 15:51:16]

LGTM

[minux1, 2012-07-28 16:24:31]

http://codereview.appspot.com/6446060/diff/7/misc/cgo/test/setgid_linux.go
File misc/cgo/test/setgid_linux.go (right):

http://codereview.appspot.com/6446060/diff/7/misc/cgo/test/setgid_linux.go#ne...
misc/cgo/test/setgid_linux.go:5: // Test that setgid does not hang on GNU/Linx.
GNU/Linux

http://codereview.appspot.com/6446060/diff/7/misc/cgo/test/setgid_linux.go#ne...
misc/cgo/test/setgid_linux.go:21: // Issue 3871.
if this file only contains this test, why not change its name
to issue3871_linux.go?

[iant, 2012-07-28 17:40:28]

http://codereview.appspot.com/6446060/diff/7/misc/cgo/test/setgid_linux.go
File misc/cgo/test/setgid_linux.go (right):

http://codereview.appspot.com/6446060/diff/7/misc/cgo/test/setgid_linux.go#ne...
misc/cgo/test/setgid_linux.go:5: // Test that setgid does not hang on GNU/Linx.
On 2012/07/28 16:24:31, minux wrote:
> GNU/Linux

Done.

http://codereview.appspot.com/6446060/diff/7/misc/cgo/test/setgid_linux.go#ne...
misc/cgo/test/setgid_linux.go:21: // Issue 3871.
On 2012/07/28 16:24:31, minux wrote:
> if this file only contains this test, why not change its name
> to issue3871_linux.go?

I think naming it setgid makes it clearer what is being tested, and saves people
having to look up the issue.  However, I added a comment pointing to the issue.

[iant, 2012-07-28 17:40:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=136f59f1d047 ***

misc/cgo/test: only run setgid test on GNU/Linux

Fixes issue 3874.

R=golang-dev, nj, r, minux.ma
CC=golang-dev
http://codereview.appspot.com/6446060