Issue 6445104: code review 6445104: syscall: add linux specific Getsockopt for Ucred struct

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6445104: code review 6445104: syscall: add linux specific Getsockopt for Ucred struct

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by andreas

Modified:
13 years, 9 months ago

Reviewers:
rsc

CC:
golang-dev, rsc, iant2

Visibility:
Public.

Description

syscall: add linux specific Getsockopt for Ucred struct SO_PEERCRED on unix domain socket will fill a Ucred struct, thus linux needs a custom Getsockopt variant. Fixes issue 3836.

Patch Set 1 #

Patch Set 2 : diff -r 62f087306b18 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 62f087306b18 https://code.google.com/p/go/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/pkg/syscall/syscall_linux.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

andreas

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 10 months ago (2012-08-11 11:16:49 UTC) #1

rsc

LGTM Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright. Thanks. Russ

13 years, 9 months ago (2012-09-11 00:53:04 UTC) #2

andreas

Thanks. No need for CLA - do I need to resubmit this as anj@google.com? Thanks. ...

13 years, 9 months ago (2012-09-11 18:58:55 UTC) #3

iant2

On Tue, Sep 11, 2012 at 11:58 AM, Andreas Jellinghaus <andreas@ionisiert.de> wrote: > Thanks. No ...

13 years, 9 months ago (2012-09-11 20:16:21 UTC) #4

iant

13 years, 9 months ago (2012-09-12 13:38:37 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=efd8fcc055aa ***

syscall: add linux specific Getsockopt for Ucred struct

SO_PEERCRED on unix domain socket will fill a Ucred struct,
thus linux needs a custom Getsockopt variant.
Fixes issue 3836.

R=golang-dev, rsc, iant
CC=golang-dev
http://codereview.appspot.com/6445104

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages