code review 6445043: misc/vim: fix :Import insertion heuristic.

misc/vim: fix :Import insertion heuristic.

If a factored import group has a blank line, assume it is dividing
separate groups of imports (e.g. standard library vs. site-specific).
        import (
                "bytes"
                "io"

                "mycorp/package"
        )

The most common case is inserting new standard library imports,
which are usually (stylistically) the first group, so we should drop
"net" in the above example immediately after "io".

Since this logic is getting non-trivial, add a test.

[dsymonds, 2012-07-25 03:36:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2012-07-28 11:17:45]

Any Vim users want to sanity check this?

[minux1, 2012-07-28 16:20:17]

could we change the heuristic to take package prefix into account?
Unable to correctly :Import mycorp/package2 is unfortunate.

[fss, 2012-07-28 16:21:52]

On 2012/07/28 11:17:45, dsymonds wrote:
> Any Vim users want to sanity check this?

It works fine for the net sample, but messes up with mycorp/package2.

[dsymonds, 2012-07-29 05:02:27]

PTAL

It's more complicated now, but site prefixes are now handled
correctly. There's also a test to verify.

[minux1, 2012-07-29 05:19:48]

LGTM.

i played with test.sh for some time, added a third import group and
a few test and i think the code is correct.

http://codereview.appspot.com/6445043/diff/8001/misc/vim/ftplugin/go/test.sh
File misc/vim/ftplugin/go/test.sh (right):

http://codereview.appspot.com/6445043/diff/8001/misc/vim/ftplugin/go/test.sh#...
misc/vim/ftplugin/go/test.sh:3: # Copyright 2011 The Go Authors. All rights
reserved.
s/2011/2012/ ?

[fss, 2012-07-29 14:58:18]

On 2012/07/29 05:02:27, dsymonds wrote:
> PTAL
> 
> It's more complicated now, but site prefixes are now handled
> correctly. There's also a test to verify.

LGTM

Nice test.

[dsymonds, 2012-07-29 22:48:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=9bf2225c38eb ***

misc/vim: fix :Import insertion heuristic.

If a factored import group has a blank line, assume it is dividing
separate groups of imports (e.g. standard library vs. site-specific).
        import (
                "bytes"
                "io"

                "mycorp/package"
        )

The most common case is inserting new standard library imports,
which are usually (stylistically) the first group, so we should drop
"net" in the above example immediately after "io".

Since this logic is getting non-trivial, add a test.

R=golang-dev, minux.ma, franciscossouza
CC=golang-dev
http://codereview.appspot.com/6445043

http://codereview.appspot.com/6445043/diff/8001/misc/vim/ftplugin/go/test.sh
File misc/vim/ftplugin/go/test.sh (right):

http://codereview.appspot.com/6445043/diff/8001/misc/vim/ftplugin/go/test.sh#...
misc/vim/ftplugin/go/test.sh:3: # Copyright 2011 The Go Authors. All rights
reserved.
On 2012/07/29 05:19:48, minux wrote:
> s/2011/2012/ ?

Done.