Added classes for command-line tool and function for computing number of unmapped glyphs

Added classes for command-line tool and function for computing number of unmapped glyphs

Apologies for the combining of unrelated functions into one code review. This was done in the interest of time, as to my knowledge, each individual code review can only be submitted after the code for the previous code review has been committed.

This code review does not contain the modification of the ant file to create the JAR for this font tool.

[yehh, 2012-08-14 04:06:25]

Added classes for command-line tool and function for computing number of
unmapped glyphs

[stuartg, 2012-08-14 20:56:12]

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
File java/src/com/google/typography/font/tools/fontinfo/CommandOptions.java
(right):

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
java/src/com/google/typography/font/tools/fontinfo/CommandOptions.java:1:
package com.google.typography.font.tools.fontinfo;
Shouldn't these all be --option? Aren't the - flags for single character
options?

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
File java/src/com/google/typography/font/tools/fontinfo/FontInfo.java (right):

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
java/src/com/google/typography/font/tools/fontinfo/FontInfo.java:345: * @param
font
why the newline?

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
java/src/com/google/typography/font/tools/fontinfo/FontInfo.java:460: return
getLocaTable(font).numGlyphs();
Probably better and more direct to look at maxp. The loca table is just storing
a copy of that.

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
java/src/com/google/typography/font/tools/fontinfo/FontInfo.java:592: public
static int numUnmappedGlyphs(Font font) {
It's not critical but these sorts of utility functions can lead to inadvertent
overhead because they have high backend costs. The end user might not realize
how much work is being done behind the scenes. Often better to let them get the
DataDisplayTable and then they have it and can query it for num and do other
things from their copy rather than recreating it.

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
File java/src/com/google/typography/font/tools/fontinfo/FontInfoMain.java
(right):

http://codereview.appspot.com/6443121/diff/1/java/src/com/google/typography/f...
java/src/com/google/typography/font/tools/fontinfo/FontInfoMain.java:232: font =
fontFactory.loadFonts(is)[0];
You should be getting all the fonts and dumping data for them all. Multiple
fonts can be in one file. See the sfntdump tool.

[stuartg, 2012-08-14 23:23:32]

http://codereview.appspot.com/6443121/diff/7001/java/src/com/google/typograph...
File java/src/com/google/typography/font/tools/fontinfo/CommandOptions.java
(right):

http://codereview.appspot.com/6443121/diff/7001/java/src/com/google/typograph...
java/src/com/google/typography/font/tools/fontinfo/CommandOptions.java:3: import
com.beust.jcommander.Parameter;
Add single char shortcuts.

Pick a reasonable default if not option given.

[stuartg, 2012-08-15 00:38:59]

LGTM