code review 6443100: cmd/gc: mark broken type declarations as broken.

cmd/gc: mark broken type declarations as broken.

This fixes a spurious 'invalid recursive type' error, and stops the compiler from emitting errors on uses of the invalid type.

Fixes issue 3766.

[DMorsing, 2012-08-07 21:52:04]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
rsc@golang.org),

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2012-08-07 22:00:08]

Thanks for fixing this bug. Please fix the date in the comment. 

On 08/08/2012, at 7:52, daniel.morsing@gmail.com wrote:

> Reviewers: golang-dev_googlegroups.com,
> 
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
> rsc@golang.org),
> 
> I'd like you to review this change to
> https://code.google.com/p/go/
> 
> 
> Description:
> cmd/gc: mark broken type declarations as broken.
> 
> This fixes a spurious 'invalid recursive type' error, and stops the
> compiler from emitting errors on uses of the invalid type.
> 
> Fixes issue 3766.
> 
> Please review this at http://codereview.appspot.com/6443100/
> 
> Affected files:
>  M src/cmd/gc/typecheck.c
>  A test/badtype.go
> 
> 
> Index: src/cmd/gc/typecheck.c
> ===================================================================
> --- a/src/cmd/gc/typecheck.c
> +++ b/src/cmd/gc/typecheck.c
> @@ -2715,6 +2715,7 @@
>    typecheck(&n->ntype, Etype);
>    if((t = n->ntype->type) == T) {
>        n->diag = 1;
> +        n->type = T;
>        goto ret;
>    }
>    if(n->type == T) {
> Index: test/badtype.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/badtype.go
> @@ -0,0 +1,10 @@
> +// errorcheck
> +
> +// Copyright 2009 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package main
> +
> +type T x.T // ERROR "undefined"
> +
> 
> 

[minux1, 2012-08-08 07:23:44]

it seems the badtype.go file should go to test/fixedbugs/bug???.go

http://codereview.appspot.com/6443100/diff/3003/test/badtype.go
File test/badtype.go (right):

http://codereview.appspot.com/6443100/diff/3003/test/badtype.go#newcode3
test/badtype.go:3: // Copyright 2009 The Go Authors. All rights reserved.
as dave said, please fix the year here.

[DMorsing, 2012-08-08 15:43:30]

Hello golang-dev@googlegroups.com, dave@cheney.net, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[DMorsing, 2012-08-23 15:42:59]

ping.

[rsc, 2012-08-31 17:01:31]

LGTM

[rsc, 2012-08-31 17:02:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=6429097c1c0f ***

cmd/gc: mark broken type declarations as broken.

This fixes a spurious 'invalid recursive type' error, and stops the compiler
from emitting errors on uses of the invalid type.

Fixes issue 3766.

R=golang-dev, dave, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6443100

Committer: Russ Cox <rsc@golang.org>

[dgryski, 2012-08-31 19:23:44]

This change appears to have overwritten bug451.go, added by nigeltao as part of
https://codereview.appspot.com/6450163

On 2012/08/31 17:02:34, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=6429097c1c0f ***
> 
> cmd/gc: mark broken type declarations as broken.
> 
> This fixes a spurious 'invalid recursive type' error, and stops the compiler
> from emitting errors on uses of the invalid type.
> 
> Fixes issue 3766.
> 
> R=golang-dev, dave, minux.ma, rsc
> CC=golang-dev
> http://codereview.appspot.com/6443100
> 
> Committer: Russ Cox <mailto:rsc@golang.org>

[rsc, 2012-08-31 19:27:42]

On Fri, Aug 31, 2012 at 3:23 PM,  <dgryski@gmail.com> wrote:
> This change appears to have overwritten bug451.go, added by nigeltao as
> part of https://codereview.appspot.com/6450163

Oops, thanks. http://codereview.appspot.com/6497066