Issue 6443071: [google/main] Add -fno-section-anchors for powerpc, workround for Google ref b/6663281

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6443071: [google/main] Add -fno-section-anchors for powerpc, workround for Google ref b/6663281

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by simonb

Modified:
12 years, 8 months ago

Reviewers:
Diego Novillo

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	gcc/testsuite/g++.dg/tree-prof/lipo/lipo.exp	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	gcc/testsuite/gcc.dg/tree-prof/lipo/lipo.exp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

simonb

Workround for Google ref b/6663281 Appends -fno-section-anchors to -fprofile-{generate,use} -fripa, for powerpc targets only. No-op ...

12 years, 8 months ago (2012-08-01 10:49:10 UTC) #1

Workround for Google ref b/6663281

Appends -fno-section-anchors to -fprofile-{generate,use} -fripa, for powerpc
targets only.  No-op for other targets.

For google/main.  Tested for bootstrap and regression.

2012-08-01  Simon Baldwin  <simonb@google.com>

	* gcc/testsuite/gcc.dg/tree-prof/lipo/lipo.exp: Append
	-fno-section-anchors to profile_option and feedback_option for
	powerpc targets.  Workround for Google ref b/6663281.
	* gcc/testsuite/g++.dg/tree-prof/lipo/lipo.exp: Likewise


Index: gcc/testsuite/gcc.dg/tree-prof/lipo/lipo.exp
===================================================================
--- gcc/testsuite/gcc.dg/tree-prof/lipo/lipo.exp	(revision 190013)
+++ gcc/testsuite/gcc.dg/tree-prof/lipo/lipo.exp	(working copy)
@@ -45,6 +45,12 @@ load_lib profopt.exp
 set profile_option "-fprofile-generate -fripa -D_PROFILE_GENERATE"
 set feedback_option "-fprofile-use -fripa -D_PROFILE_USE"
 
+# Add -fno-section-anchors for powerpc.  Workround for Google ref b/6663281
+if {[istarget powerpc*-*-*]} {
+    set profile_option "$profile_option -fno-section-anchors"
+    set feedback_option "$feedback_option -fno-section-anchors"
+}
+
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/*_0.c]] {
     # If we're only testing specific files and this isn't one of them, skip
it.
     if ![runtest_file_p $runtests $src] then {
Index: gcc/testsuite/g++.dg/tree-prof/lipo/lipo.exp
===================================================================
--- gcc/testsuite/g++.dg/tree-prof/lipo/lipo.exp	(revision 190013)
+++ gcc/testsuite/g++.dg/tree-prof/lipo/lipo.exp	(working copy)
@@ -45,6 +45,12 @@ load_lib profopt.exp
 set profile_option "-fprofile-generate -fripa"
 set feedback_option "-fprofile-use -fripa"
 
+# Add -fno-section-anchors for powerpc.  Workround for Google ref b/6663281
+if {[istarget powerpc*-*-*]} {
+    set profile_option "$profile_option -fno-section-anchors"
+    set feedback_option "$feedback_option -fno-section-anchors"
+}
+
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/*_0.C]] {
     # If we're only testing specific files and this isn't one of them, skip
it.
     if ![runtest_file_p $runtests $src] then {

--
This patch is available for review at http://codereview.appspot.com/6443071

Diego Novillo

12 years, 8 months ago (2012-08-01 13:55:27 UTC) #2

On 12-08-01 03:49 , Simon Baldwin wrote:
> Workround for Google ref b/6663281
>
> Appends -fno-section-anchors to -fprofile-{generate,use} -fripa, for powerpc
> targets only.  No-op for other targets.
>
> For google/main.  Tested for bootstrap and regression.
>
> 2012-08-01  Simon Baldwin  <simonb@google.com>
>
> 	* gcc/testsuite/gcc.dg/tree-prof/lipo/lipo.exp: Append
> 	-fno-section-anchors to profile_option and feedback_option for
> 	powerpc targets.  Workround for Google ref b/6663281.
> 	* gcc/testsuite/g++.dg/tree-prof/lipo/lipo.exp: Likewise

OK.


Diego.

Expand All Messages | Collapse All Messages