Issue 6442049: code review 6442049: cmd/gc: fix inlining bug with receive operator.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6442049: code review 6442049: cmd/gc: fix inlining bug with receive operator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by remyoudompheng

Modified:
12 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev, remy_archlinux.org

Visibility:
Public.

Description

cmd/gc: fix inlining bug with receive operator. The receive operator was given incorrect precedence resulting in incorrect deletion of parentheses. Fixes issue 3843.

Patch Set 1 #

Patch Set 2 : diff -r c87a4b5ad6d7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c87a4b5ad6d7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 18f07a49fb53 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
M	src/cmd/gc/fmt.c	View	1	2 chunks	+1 line, -1 line	0 comments	Download
A	test/fixedbugs/bug448.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug448.dir/pkg1.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug448.dir/pkg2.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2012-07-26 05:56:48 UTC) #1

remyoudompheng

This CL preferably needs CL 6440048 (http://codereview.appspot.com/6440048) to be applied first, otherwise the test will ...

12 years, 10 months ago (2012-07-26 05:57:44 UTC) #2

remyoudompheng

12 years, 9 months ago (2012-07-31 22:45:41 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d872ed20fccb ***

cmd/gc: fix inlining bug with receive operator.

The receive operator was given incorrect precedence
resulting in incorrect deletion of parentheses.

Fixes issue 3843.

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/6442049

Expand All Messages | Collapse All Messages