Issue 6441093: [google/main] Omit TARGET_LIB_PATH from RPATH_ENVVAR in HOST_EXPORTS on bootstrap builds

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by simonb

Modified:
11 years, 9 months ago

Reviewers:
Diego Novillo, Ollie Wild

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/

Visibility:
Public.

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	Makefile.in	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	Makefile.tpl	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

simonb

Omit TARGET_LIB_PATH from RPATH_ENVVAR in HOST_EXPORTS on bootstrap builds. Discussion and rationale at: http://gcc.gnu.org/ml/gcc/2012-06/msg00314.html For ...

11 years, 9 months ago (2012-08-02 11:37:37 UTC) #1

Ollie Wild

OK. On Aug 2, 2012 6:37 AM, "Simon Baldwin" <simonb@google.com> wrote: > Omit TARGET_LIB_PATH from ...

11 years, 9 months ago (2012-08-07 12:45:40 UTC) #2

OK.
On Aug 2, 2012 6:37 AM, "Simon Baldwin" <simonb@google.com> wrote:

> Omit TARGET_LIB_PATH from RPATH_ENVVAR in HOST_EXPORTS on bootstrap builds.
>
> Discussion and rationale at:
> http://gcc.gnu.org/ml/gcc/2012-06/msg00314.html
>
> For google/main.  Tested for bootstrap and regression.
>
> 2012-08-02  Simon Baldwin  <simonb@google.com>
>
>         * Makefile.tpl: Omit TARGET_LIB_PATH from RPATH_ENVVAR set in
>         HOST_EXPORTS on bootstrap builds.
>         * Makefile.in: Regenerate.
>
>
> Index: Makefile.in
> ===================================================================
> --- Makefile.in (revision 190013)
> +++ Makefile.in (working copy)
> @@ -225,9 +225,6 @@ HOST_EXPORTS = \
>         CLOOGINC="$(HOST_CLOOGINC)"; export CLOOGINC; \
>         LIBELFLIBS="$(HOST_LIBELFLIBS)" ; export LIBELFLIBS; \
>         LIBELFINC="$(HOST_LIBELFINC)" ; export LIBELFINC; \
> -@if gcc-bootstrap
> -       $(RPATH_ENVVAR)=`echo "$(TARGET_LIB_PATH)$$$(RPATH_ENVVAR)" | sed
> 's,::*,:,g;s,^:*,,;s,:*$$,,'`; export $(RPATH_ENVVAR); \
> -@endif gcc-bootstrap
>         $(RPATH_ENVVAR)=`echo "$(HOST_LIB_PATH)$$$(RPATH_ENVVAR)" | sed
> 's,::*,:,g;s,^:*,,;s,:*$$,,'`; export $(RPATH_ENVVAR);
>
>  POSTSTAGE1_CXX_EXPORT = \
> Index: Makefile.tpl
> ===================================================================
> --- Makefile.tpl        (revision 190013)
> +++ Makefile.tpl        (working copy)
> @@ -228,9 +228,6 @@ HOST_EXPORTS = \
>         CLOOGINC="$(HOST_CLOOGINC)"; export CLOOGINC; \
>         LIBELFLIBS="$(HOST_LIBELFLIBS)" ; export LIBELFLIBS; \
>         LIBELFINC="$(HOST_LIBELFINC)" ; export LIBELFINC; \
> -@if gcc-bootstrap
> -       $(RPATH_ENVVAR)=`echo "$(TARGET_LIB_PATH)$$$(RPATH_ENVVAR)" | sed
> 's,::*,:,g;s,^:*,,;s,:*$$,,'`; export $(RPATH_ENVVAR); \
> -@endif gcc-bootstrap
>         $(RPATH_ENVVAR)=`echo "$(HOST_LIB_PATH)$$$(RPATH_ENVVAR)" | sed
> 's,::*,:,g;s,^:*,,;s,:*$$,,'`; export $(RPATH_ENVVAR);
>
>  POSTSTAGE1_CXX_EXPORT = \
>
> --
> This patch is available for review at
> http://codereview.appspot.com/6441093
>

Diego Novillo

11 years, 9 months ago (2012-08-07 13:36:17 UTC) #3

On Thu, Aug 2, 2012 at 7:37 AM, Simon Baldwin <simonb@google.com> wrote:
> Omit TARGET_LIB_PATH from RPATH_ENVVAR in HOST_EXPORTS on bootstrap builds.
>
> Discussion and rationale at: http://gcc.gnu.org/ml/gcc/2012-06/msg00314.html
>
> For google/main.  Tested for bootstrap and regression.
>
> 2012-08-02  Simon Baldwin  <simonb@google.com>
>
>         * Makefile.tpl: Omit TARGET_LIB_PATH from RPATH_ENVVAR set in
>         HOST_EXPORTS on bootstrap builds.
>         * Makefile.in: Regenerate.

This is OK.

Does this belong in google/integration? Or will you be sending this
for trunk? If you're not going to be sending this to trunk, please put
it in google/integration.



Diego.

Expand All Messages | Collapse All Messages