Add rootitem search capability. Search only in subitems of rootitem (including transcluded items).

Add rootitem search capability. Search only in subitems of rootitem (including transcluded items).

[Reimar Bauer, 2012-07-27 20:21:38]

some comments

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:238: filter = None
_filter

because that is a builtin

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:243: def extract_trancluded_names(item_name):
that may be could be extracted

look also at _compute_item_sets

[Reimar Bauer, 2012-07-27 20:21:40]

some comments

[ThomasJWaldmann, 2012-07-29 12:51:10]

patchset1 comments

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:239: rootitem = request.values.get('rootitem')
is rootitem == u"FooBar" or u"FooBar/" ?

depeding on what you have here, you maybe have to add a "/" at some places to
avoid getting "FooBarBaz" as a incorrect subitem.

Note that with the slash added, it won't match the rootitem itself any more.

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:243: def extract_trancluded_names(item_name):
typo in function name

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:266: # XXX Will whoosh be satisfied with such a
large filter query?
you mean whether it can cope with it? no idea, i hope so. :)

http://codereview.appspot.com/6441063/diff/1/MoinMoin/templates/layout.html
File MoinMoin/templates/layout.html (right):

http://codereview.appspot.com/6441063/diff/1/MoinMoin/templates/layout.html#n...
MoinMoin/templates/layout.html:14: If there is no header_search macro defined in
child templates use the "Global search" macro. #}
well, the question then is "how do you do a global search on e.g. a blog page".
do we really just want overwrite the global search with the "local" one? will
users understand that it is a different search sometimes?

http://codereview.appspot.com/6441063/diff/1/MoinMoin/templates/search.html
File MoinMoin/templates/search.html (right):

http://codereview.appspot.com/6441063/diff/1/MoinMoin/templates/search.html#n...
MoinMoin/templates/search.html:22: {{ forms.render(medium_search_form['q'],
placeholder=_("Search Queue")) }}
Queue? Query?

[ThomasJWaldmann, 2012-07-29 13:02:02]

the "local search" url pattern is nice, but i think we should first think about
usability (do we want 1 or 2 search fields? or 1 search field and a checkbox
"only search this item and subitems"?) and then decide implementation.

if we just want one search on the blog view, i think the patchset 2 approach is
maybe nicer.

http://codereview.appspot.com/6441063/diff/2001/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6441063/diff/2001/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:225:
@frontend.route('/+search/<itemname:item_name>', methods=['GET', 'POST'])
this is a nice idea, consistent with some other url patterns.

[spy, 2012-08-02 19:06:18]

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:238: filter = None
On 2012/07/27 20:21:39, Reimar Bauer wrote:
> _filter
> 
> because that is a builtin

fixed

http://codereview.appspot.com/6441063/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:243: def extract_trancluded_names(item_name):
On 2012/07/29 12:51:10, ThomasJWaldmann wrote:
> typo in function name

Done.

http://codereview.appspot.com/6441063/diff/1/MoinMoin/templates/search.html
File MoinMoin/templates/search.html (right):

http://codereview.appspot.com/6441063/diff/1/MoinMoin/templates/search.html#n...
MoinMoin/templates/search.html:22: {{ forms.render(medium_search_form['q'],
placeholder=_("Search Queue")) }}
On 2012/07/29 12:51:10, ThomasJWaldmann wrote:
> Queue? Query?

Of course Query, fixed.

[ThomasJWaldmann, 2012-08-02 23:02:34]

ok, small comment on grammar.

http://codereview.appspot.com/6441063/diff/3012/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6441063/diff/3012/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:225: """Compute a set of transcluded into
*item_name* item names."""
compute which items are transcluded into item <item_name>.
return a set of their item names.