code review 6441048: log/syslog: don't append \n if there is one

log/syslog: don't append \n if there is one
   pkg log already appends a linefeed to the log message,
so log/syslog doesn't need to append another.

[minux1, 2012-07-25 22:20:04]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-07-25 22:26:54]

http://codereview.appspot.com/6441048/diff/5004/src/pkg/log/syslog/syslog.go
File src/pkg/log/syslog/syslog.go (right):

http://codereview.appspot.com/6441048/diff/5004/src/pkg/log/syslog/syslog.go#...
src/pkg/log/syslog/syslog.go:143: fs += "\n"
instead of making a new string here, could the pattern just include "%s" instead
of "\n" at the end, and then introduce a "suffix" or "nl" variable?

http://codereview.appspot.com/6441048/diff/5004/src/pkg/log/syslog/syslog.go#...
src/pkg/log/syslog/syslog.go:155: fs += "\n"
likewise

[minux1, 2012-07-25 22:39:30]

PTAL.

On 2012/07/25 22:26:54, bradfitz wrote:
http://codereview.appspot.com/6441048/diff/5004/src/pkg/log/syslog/syslog.go#...
> src/pkg/log/syslog/syslog.go:143: fs += "\n"
> instead of making a new string here, could the pattern just include "%s"
instead
> of "\n" at the end, and then introduce a "suffix" or "nl" variable?
all done.

[r, 2012-07-27 00:50:37]

http://codereview.appspot.com/6441048/diff/12002/src/pkg/log/syslog/syslog.go
File src/pkg/log/syslog/syslog.go (right):

http://codereview.appspot.com/6441048/diff/12002/src/pkg/log/syslog/syslog.go...
src/pkg/log/syslog/syslog.go:142: if b[len(b)-1] != '\n' {
what if len(b)==0?

http://codereview.appspot.com/6441048/diff/12002/src/pkg/log/syslog/syslog.go...
src/pkg/log/syslog/syslog.go:154: if s[len(s)-1] != '\n' {
ditto

[minux1, 2012-07-27 01:08:48]

PTAL.
On 2012/07/27 00:50:37, r wrote:
http://codereview.appspot.com/6441048/diff/12002/src/pkg/log/syslog/syslog.go...
> src/pkg/log/syslog/syslog.go:142: if b[len(b)-1] != '\n' {
> what if len(b)==0?
fixed, also added a test.

[r, 2012-07-27 04:29:20]

LGTM

[minux1, 2012-07-27 18:22:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=6556a8d85dd6 ***

log/syslog: don't append \n if there is one
   pkg log already appends a linefeed to the log message,
so log/syslog doesn't need to append another.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/6441048