Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(573)

Issue 6432060: code review 6432060: cgo: fix declarations in _cgo_export.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by iant
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

cgo: fix declarations in _cgo_export.c Declare crosscall2. Declare the functions passed to it as returning void, rather than relying on implicit return type.

Patch Set 1 #

Patch Set 2 : diff -r bfe5e28a0484 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/cmd/cgo/out.go View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-07-21 16:57:02 UTC) #1
iant
Ping. (It's a small patch.)
12 years, 9 months ago (2012-07-25 16:41:49 UTC) #2
minux1
LGTM.
12 years, 9 months ago (2012-07-25 18:00:48 UTC) #3
iant
12 years, 9 months ago (2012-07-25 21:14:41 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=6751a0e1a6a4 ***

cgo: fix declarations in _cgo_export.c

Declare crosscall2.  Declare the functions passed to it as
returning void, rather than relying on implicit return type.

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6432060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b