Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4061)

Issue 6431044: fix repeat-sign problems introduced with issue 2533

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by benko.pal
Modified:
11 years, 9 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

fix repeat-sign problems introduced with issue 2533 This reverts commit d05afb4c0bf29cbd6a98691c9c62afa1604fa4b2, i.e. applies (a modified version of) 2a872121379fffe7b1cd5d23048b7ea04b4d1f68. modifications relative to the latter are - dot size is queried (not hardcoded) when printing a repeat sign - bar line extent is shrunk not by scaling but cutting - new regtests for repeat sign in exotic staves (non-default staff size, line count, line positions)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -62 lines) Patch
M input/regression/ledger-lines-varying-staves.ly View 1 chunk +3 lines, -3 lines 0 comments Download
M input/regression/non-centered-bar-lines.ly View 1 chunk +1 line, -0 lines 0 comments Download
A input/regression/repeat-sign.ly View 1 chunk +74 lines, -0 lines 0 comments Download
A input/regression/repeat-sign-global-size-10.ly View 1 chunk +53 lines, -0 lines 0 comments Download
A input/regression/repeat-sign-global-size-30.ly View 1 chunk +57 lines, -0 lines 0 comments Download
A input/regression/repeat-sign-layout-size.ly View 1 chunk +53 lines, -0 lines 0 comments Download
M input/regression/staff-ledger-positions.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/staff-line-positions.ly View 1 chunk +1 line, -3 lines 0 comments Download
M input/regression/zero-staff-space.ly View 1 chunk +1 line, -1 line 0 comments Download
M lily/bar-line.cc View 3 chunks +68 lines, -10 lines 0 comments Download
M lily/beam.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M lily/breathing-sign.cc View 3 chunks +15 lines, -19 lines 0 comments Download
M lily/custos.cc View 2 chunks +1 line, -2 lines 0 comments Download
M lily/rest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M lily/rest-collision.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M lily/slur-scoring.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/time-signature.cc View 2 chunks +30 lines, -2 lines 0 comments Download
M lily/vaticana-ligature.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
benko.pal
patch enhanced to fix http://code.google.com/p/lilypond/issues/detail?id=2648 if anyone wants to run regtests, please run both versions ...
11 years, 9 months ago (2012-07-18 20:56:50 UTC) #1
Keith
LGTM. I uploaded the two versions of the line-count fixes at http://codereview.appspot.com/6351107/diff2/1:2001/lily/bar-line.cc so we can ...
11 years, 9 months ago (2012-07-19 17:22:21 UTC) #2
benko.pal
11 years, 9 months ago (2012-07-21 14:34:53 UTC) #3
sorry, after juggling with git branches the new version is at
http://codereview.appspot.com/6419064
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b