code review 6428072: encoding/gob: revert 6348067, which broke compatibility

encoding/gob: revert 6348067, which broke compatibility
Add commentary to explain better what's going on, but the
code change is a simple one-line reversal to the previous
form.

[r, 2012-07-23 18:59:53]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-07-23 19:10:33]

LGTM

http://codereview.appspot.com/6428072/diff/3/src/pkg/encoding/gob/type.go
File src/pkg/encoding/gob/type.go (right):

http://codereview.appspot.com/6428072/diff/3/src/pkg/encoding/gob/type.go#new...
src/pkg/encoding/gob/type.go:758: // TODO: This next line briefly said "rt =
pt.Elem()" because that looks
I was wrong about the type T *X stuff, because the two cases rt.Name() == "" and
rt.Name() != "" are mutually exclusive. So star cannot possibly get used (not
that I am suggesting to edit the code).

// NOTE: The following line should be rt = pt.Elem() in order to implement
// what the comment above claims, but fixing it would break compatibility
// with existing gobs.
//
// Given package p imported as "full/p" with these definitions:
//     package p
//     type T1 struct { ... }
// this table shows the intended and actual strings used by gob to
// name the types: 
//
// Type      Correct string     Actual string
//
// T1        full/p.T1          full/p.T1
// *T1       *full/p.T1         *p.T1
//
// The missing full path cannot be fixed without breaking existing gob readers.

[r, 2012-07-23 20:35:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=3357d8d34ab8 ***

encoding/gob: revert 6348067, which broke compatibility
Add commentary to explain better what's going on, but the
code change is a simple one-line reversal to the previous
form.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6428072