Issue 6427062: code review 6427062: freetype: move the scaling from FUnits to pixels from p...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6427062: code review 6427062: freetype: move the scaling from FUnits to pixels from p... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by nigeltao

Modified:
12 years, 4 months ago

Reviewers:

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

freetype: move the scaling from FUnits to pixels from package freetype to package truetype.

Patch Set 2 : diff -r c64c75ce4f62 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r c64c75ce4f62 https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r c64c75ce4f62 https://code.google.com/p/freetype-go #

Total comments: 2

Patch Set 5 : diff -r c64c75ce4f62 https://code.google.com/p/freetype-go #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -116 lines)			Patch
M	example/freetype/main.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	example/truetype/main.go	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
M	freetype/freetype.go	View	1	8 chunks	+23 lines, -56 lines	0 comments	Download
M	freetype/truetype/glyph.go	View	1 2 3 4	6 chunks	+29 lines, -14 lines	0 comments	Download
M	freetype/truetype/hint.go	View	1 2 3 4	4 chunks	+7 lines, -4 lines	0 comments	Download
M	freetype/truetype/hint_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	freetype/truetype/truetype.go	View	1 2 3 4	7 chunks	+50 lines, -27 lines	0 comments	Download
M	freetype/truetype/truetype_test.go	View	1	1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

12 years, 4 months ago (2012-07-24 13:09:52 UTC) #1

bsiegert

LGTM http://codereview.appspot.com/6427062/diff/8001/freetype/truetype/glyph.go File freetype/truetype/glyph.go (right): http://codereview.appspot.com/6427062/diff/8001/freetype/truetype/glyph.go#newcode109 freetype/truetype/glyph.go:109: // the resultant glyph will be hinted by ...

12 years, 4 months ago (2012-07-24 18:56:28 UTC) #2

nigeltao

12 years, 4 months ago (2012-07-25 12:12:11 UTC) #3

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=15b6d4e04151 ***

freetype: move the scaling from FUnits to pixels from package freetype
to package truetype.

R=bsiegert
CC=golang-dev
http://codereview.appspot.com/6427062

Expand All Messages | Collapse All Messages