Fix supertags widget. Clicking on supertags modify the filter for the blog entries main listing.

Fix supertags widget. Clicking on supertags modify the filter for the blog entries main listing.

[Reimar Bauer, 2012-07-25 09:56:02]

some comments

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/blog.html
File MoinMoin/templates/blog.html (right):

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/blog.html#new...
MoinMoin/templates/blog.html:5: {% set no_entries_msg = _("There are no entries
in this blog category.") %}
should be there the value of the supertag in that message?

Or you never know that it had not the supertag.

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/layout.html
File MoinMoin/templates/layout.html (right):

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/layout.html#n...
MoinMoin/templates/layout.html:2: {% extends "base.html" %}
changes here look like a PEP8 fix, tabs replaced by blanks

Please do that in a separate changeset.

[spy, 2012-07-25 13:13:30]

answered

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/blog.html
File MoinMoin/templates/blog.html (right):

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/blog.html#new...
MoinMoin/templates/blog.html:5: {% set no_entries_msg = _("There are no entries
in this blog category.") %}
On 2012/07/25 09:56:02, Reimar Bauer wrote:
> should be there the value of the supertag in that message?
> 
> Or you never know that it had not the supertag.
> 

Added the name of the selected category to this message.

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/layout.html
File MoinMoin/templates/layout.html (right):

http://codereview.appspot.com/6420063/diff/1/MoinMoin/templates/layout.html#n...
MoinMoin/templates/layout.html:2: {% extends "base.html" %}
On 2012/07/25 09:56:02, Reimar Bauer wrote:
> changes here look like a PEP8 fix, tabs replaced by blanks
> 
> Please do that in a separate changeset.

I added the block pagepath and saw that some lines look ugly inside it because
of wrong indentations. Should I move such changes in a seperate changeset?

[ThomasJWaldmann, 2012-07-31 09:41:16]

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:475: If supertag GET-parameter is defined, the
list of blog entries consist only
consists

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:491: Prefix(NAME_EXACT, prefix),
trailing slash needed?

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/constants/keys.py
File MoinMoin/constants/keys.py (right):

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/constants/keys.py#ne...
MoinMoin/constants/keys.py:88: PTIME = u"ptime"
please merge main repo and read the comment i gave at the top of this file.

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/templates/blog_layou...
File MoinMoin/templates/blog_layout.html (right):

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/templates/blog_layou...
MoinMoin/templates/blog_layout.html:18: {{ _("It is not published yet.") }}
hmm, either just "Not published yet." or "This is not published yet." sounds
better imho. But better ask a native speaker.

[spy, 2012-07-31 20:30:11]

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:475: If supertag GET-parameter is defined, the
list of blog entries consist only
On 2012/07/31 09:41:16, ThomasJWaldmann wrote:
> consists

Done.

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:491: Prefix(NAME_EXACT, prefix),
On 2012/07/31 09:41:16, ThomasJWaldmann wrote:
> trailing slash needed?

Sure, there could be listed myblogFoo, myblogBar,... without trailing slash. But
we only want subitems of myblog/

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/constants/keys.py
File MoinMoin/constants/keys.py (right):

http://codereview.appspot.com/6420063/diff/2002/MoinMoin/constants/keys.py#ne...
MoinMoin/constants/keys.py:88: PTIME = u"ptime"
On 2012/07/31 09:41:16, ThomasJWaldmann wrote:
> please merge main repo and read the comment i gave at the top of this file.

already familiar with that, thx.