Correct makelsr handling of local update

I omitted to specify properly what makelsr should do when it's doing a "local" update - i.e. with no tarball specified.  In this case it should only update snippets/new into snippets.  This patch fixes that.

[PhilEHolmes, 2012-07-18 16:02:16]

A small patch to fix makelsr's handling of local updates.  Don't want to wait
for countdown, but a review by those who understand this would be helpful.

[PhilEHolmes, 2012-07-18 16:38:17]

Minor error

http://codereview.appspot.com/6416045/diff/1/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (right):

http://codereview.appspot.com/6416045/diff/1/scripts/auxiliar/makelsr.py#newc...
scripts/auxiliar/makelsr.py:312: if len(args) > 0:
This should be len(tags)

[PhilEHolmes, 2012-07-18 17:05:35]

A couple of other fixes - the tags list was getting over-written, which created
some odd file-lists; and sorting the tags list means the snippets have a
consistent ordering of the lsrtag items.

[PhilEHolmes, 2012-07-18 17:05:56]

A couple of further minor updates.

[John Mandereau, 2012-07-18 19:33:15]

I tested makelsr without arguments.  I kinda works, but I'd like the
snippet-list files to be updated when a tag is added or removed from a snippet.

I'm working on a patch for this.

http://codereview.appspot.com/6416045/diff/4001/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (right):

http://codereview.appspot.com/6416045/diff/4001/scripts/auxiliar/makelsr.py#n...
scripts/auxiliar/makelsr.py:162: tags.sort()
Good. In case of a local update (i.e. if not len (args)), I'd get the tag list
from the snippets list files.

http://codereview.appspot.com/6416045/diff/4001/scripts/auxiliar/makelsr.py#n...
scripts/auxiliar/makelsr.py:313: 
This is an improvement, but with this change, if you delete or move a snippet in
Documentation/snippets/new, the old snippet file will persist in
Documentation/snippets. I suggest to delete all files in Documentation/snippets
that contain ("generated from %s" % new_lys) in case of a local update.

[email_philholmes.net, 2012-07-18 19:39:58]

----- Original Message ----- 
From: <john.mandereau@gmail.com>
To: <PhilEHolmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Wednesday, July 18, 2012 8:33 PM
Subject: Re: Correct makelsr handling of local update (issue 6416045)


>I tested makelsr without arguments.  I kinda works, but I'd like the
> snippet-list files to be updated when a tag is added or removed from a
> snippet.
>
> I'm working on a patch for this.
>
>
> http://codereview.appspot.com/6416045/diff/4001/scripts/auxiliar/makelsr.py
> File scripts/auxiliar/makelsr.py (right):
>
>
http://codereview.appspot.com/6416045/diff/4001/scripts/auxiliar/makelsr.py#n...
> scripts/auxiliar/makelsr.py:162: tags.sort()
> Good. In case of a local update (i.e. if not len (args)), I'd get the
> tag list from the snippets list files.
>
>
http://codereview.appspot.com/6416045/diff/4001/scripts/auxiliar/makelsr.py#n...
> scripts/auxiliar/makelsr.py:313:
> This is an improvement, but with this change, if you delete or move a
> snippet in Documentation/snippets/new, the old snippet file will persist
> in Documentation/snippets. I suggest to delete all files in
> Documentation/snippets that contain ("generated from %s" % new_lys) in
> case of a local update.
>
> http://codereview.appspot.com/6416045/

I pushed this about 30 seconds before your comments.  TBH I think the best 
way of working is to put a patch up for comment, but push if you want - 
we're going to be the only people running the script, so we can keep 
updating and correcting it.  Please feel free to add the functionality 
you're suggesting.

--
Phil Holmes 

[John Mandereau, 2012-07-18 19:51:46]

Il giorno mer, 18/07/2012 alle 20.39 +0100, Phil Holmes ha scritto:
> I pushed this about 30 seconds before your comments.  TBH I think the best 
> way of working is to put a patch up for comment, but push if you want - 
> we're going to be the only people running the script, so we can keep 
> updating and correcting it.  Please feel free to add the functionality 
> you're suggesting.

As we're not fiddling with makefiles, only with makelsr, I'm fine with
this workflow.

Cheers,
John