Issue 6408044: code review 6408044: devip: add support for IPv6

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6408044: code review 6408044: devip: add support for IPv6 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by 0intro

Modified:
12 years, 4 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

devip: add support for IPv6 Addresses are now stored as uchar[16] instead of ulong, with enough room for IPv6. Generic IP functions have been removed from devip.c and replaced by libip, imported from Plan 9. Names and addresses are resolved using either gethostbyname() or getaddrinfo() functions. On Windows, IPv6 name resolution is not enabled, because mingw32 doesn't provide inet_ntop().

Patch Set 1 #

Patch Set 2 : diff -r 9822f642bd61 https://bitbucket.org/rsc/drawterm #

Patch Set 3 : diff -r 9822f642bd61 https://code.google.com/p/drawterm/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+856 lines, -275 lines)			Patch
M	CONTRIBUTORS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Makefile	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
A	include/ip.h	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	kern/devip.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	kern/devip.c	View	1	18 chunks	+38 lines, -183 lines	0 comments	Download
M	kern/devip-posix.c	View	1	8 chunks	+102 lines, -41 lines	0 comments	Download
M	kern/devip-win32.c	View	1	7 chunks	+91 lines, -40 lines	0 comments	Download
M	kern/fns.h	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
A	libip/Makefile	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	libip/bo.c	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download
A	libip/classmask.c	View	1	1 chunk	+86 lines, -0 lines	0 comments	Download
A	libip/eipfmt.c	View	1	1 chunk	+109 lines, -0 lines	0 comments	Download
A	libip/ipaux.c	View	1	1 chunk	+102 lines, -0 lines	0 comments	Download
A	libip/parseip.c	View	1	1 chunk	+184 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to https://bitbucket.org/rsc/drawterm

12 years, 5 months ago (2012-07-14 19:51:41 UTC) #1

0intro

12 years, 4 months ago (2012-08-03 19:30:25 UTC) #4

*** Submitted as http://code.google.com/p/drawterm/source/detail?r=a43b5147ae91
***

devip: add support for IPv6

Addresses are now stored as uchar[16] instead
of ulong, with enough room for IPv6.

Generic IP functions have been removed from
devip.c and replaced by libip, imported from
Plan 9.

Names and addresses are resolved using either
gethostbyname() or getaddrinfo() functions.

On Windows, IPv6 name resolution is not enabled,
because mingw32 doesn't provide inet_ntop().

R=rsc
http://codereview.appspot.com/6408044

Expand All Messages | Collapse All Messages