Issue 6405057: code review 6405057: disk/mkfs, disk/mkext: add from Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6405057: code review 6405057: disk/mkfs, disk/mkext: add from Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by rsc

Modified:
12 years, 6 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

disk/mkfs, disk/mkext: add from Plan 9

Patch Set 1 #

Patch Set 2 : diff -r a615f2949b1f https://code.google.com/p/plan9port #

Patch Set 3 : diff -r a615f2949b1f https://code.google.com/p/plan9port #

Patch Set 4 : diff -r ae14cdd24cf3 https://code.google.com/p/plan9port #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1355 lines, --1 lines)			Patch
A	bin/disk/.placeholder	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	man/man8/mkfs.8	View	1	1 chunk	+187 lines, -0 lines	0 comments	Download
A	src/cmd/disk/mkext.c	View	1	1 chunk	+318 lines, -0 lines	0 comments	Download
A	src/cmd/disk/mkfile	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	src/cmd/disk/mkfs.c	View	1	1 chunk	+840 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

12 years, 6 months ago (2012-07-17 23:10:08 UTC) #1

rsc

12 years, 6 months ago (2012-07-17 23:10:52 UTC) #2

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=66e1870e8dc5
***

disk/mkfs, disk/mkext: add from Plan 9

R=rsc, rsc
http://codereview.appspot.com/6405057

Expand All Messages | Collapse All Messages