Issue 6404046: code review 6404046: go.crypto/ssh: avoid recover() when handling invalid channel ids

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6404046: code review 6404046: go.crypto/ssh: avoid recover() when handling invalid channel ids (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by dave

Modified:
11 years, 9 months ago

Reviewers:

CC:
agl1, gpaul, golang-dev

Visibility:
Public.

Description

go.crypto/ssh: avoid recover() when handling invalid channel ids This proposal removes the use of recover() to catch invalid channel ids sent from the remote side. The recover() unfortuntaly makes debugging harder as it obscures other panic causes. Another source of panic()s exists inside marshal.go, which will be handled with in a later CL.

Patch Set 1 #

Patch Set 2 : code review 6404046: go.crypto/ssh: check remote id is a valid channel #

Patch Set 3 : diff -r 671a975c2b5f https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 671a975c2b5f https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 671a975c2b5f https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 8738a06cfeef https://code.google.com/p/go.crypto #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -19 lines)			Patch
	M	ssh/client.go	View	1 2 3 4	5 chunks	+52 lines, -19 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years, 9 months ago (2012-07-16 03:47:45 UTC) #1

dave_cheney.net

11 years, 9 months ago (2012-07-17 00:59:28 UTC) #4

*** Submitted as
http://code.google.com/p/go/source/detail?r=b1b686ab459a&repo=crypto ***

go.crypto/ssh: avoid recover() when handling invalid channel ids

This proposal removes the use of recover() to catch
invalid channel ids sent from the remote side. The
recover() unfortuntaly makes debugging harder as it
obscures other panic causes.

Another source of panic()s exists inside marshal.go,
which will be handled with in a later CL.

R=agl, gustav.paul
CC=golang-dev
http://codereview.appspot.com/6404046

Expand All Messages | Collapse All Messages