code review 6397047: vacfs: fix create srv with ORCLOSE on plan 9

vacfs: fix create srv with ORCLOSE on plan 9

In the current code, the srv file is removed
just after the main thread exits, while the
srv thread is still running, which is not
the expected behavior.
We moved the srv creation just before the
procrfork, in order that the srv file will
not be removed until the srv thread exits.

[0intro, 2012-07-14 13:16:00]

Hello rsc,

I'd like you to review this change to
https://code.google.com/p/plan9port

[rsc, 2012-07-29 22:52:29]

I think a better fix might be to move this up above the procrfork, so
that the parent inherits the fd. The idea is that when the parent
exits (or crashes) the final ref to the fd is closed and the /srv
entry gets removed automatically. The idea is just incorrectly
implemented in the current code.

Russ

[0intro, 2012-07-30 08:12:12]

Hello rsc@golang.org,

Please take another look.

[rsc, 2012-08-03 18:46:12]

LGTM

[0intro, 2012-08-03 19:12:35]

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=059296ef16f1
***

vacfs: fix create srv with ORCLOSE on plan 9

In the current code, the srv file is removed
just after the main thread exits, while the
srv thread is still running, which is not
the expected behavior.
We moved the srv creation just before the
procrfork, in order that the srv file will
not be removed until the srv thread exits.

R=rsc
http://codereview.appspot.com/6397047