DescriptionUpdated for Dart's removal of string-concatenation.
CanvasDraw, DebugDraw, World:
- Documented that CanvasDraw mutates its arguments.
- Fixed DebugDraw.e_* comments to apply to correct lines.
- Fixed broken drawJoint() (CanvasDraw's argument mutation broke joints when they were rendered).
- Fixed broken drawPolygon() (CanvasDraw's argument mutation broke AABB rendering). Did this by refactoring with drawSolidPolygon().
- Refactored drawCircle(), drawSolidCircle() and drawPoint() in same way.
- Renamed drawPoint()'s argument names to be consistent with API.
- Removed redundant DebugDraw.drawPolygon() implementation.
- Implemented drawTransform().
- Reordered CanvasDraw methods to group more logically.
- Made drawSolidCircle()'s unused "axis" argument optional and API-consistant with drawCircle().
- Added DebugDraw.e_lineDrawingBit and use for selecting line-drawn debug drawing (usually clearer for diagnosis).
Color3f: Added == implementation.
IViewportTransform: Added missing scale setter.
Added extra demo "BoxTest" solely demonstrating a bouncing box.
Minor bug fixes.
Have regenerated docs and demo JS files locally but omitted from review since they obscure actual changes.
Doc generated with:
dart $DART_SDK/lib/dartdoc/dartdoc.dart --out=doc lib/box2d.dart
(which generates a *lot* of files including PNGs (which may want omitting from Git repo?))
JS generated (without -c) for all demo/*.dart bar demo.dart.
Would assume to include all of these in final commit.
Patch Set 1 #
Total comments: 30
Patch Set 2 : Updated changes from review + recent master changes. #
Total comments: 11
Patch Set 3 : Changes from CR round 3. #
MessagesTotal messages: 16
|