Issue 6373046: code review 6373046: libventi: fix segfault in vtgetreq

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6373046: code review 6373046: libventi: fix segfault in vtgetreq (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by 0intro

Modified:
11 years, 9 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

libventi: fix segfault in vtgetreq Don't call vtlog() when _vtqrecv() returns nil on queue hangup, as reported on http://bitbucket.org/rsc/plan9port/issue/102/

Patch Set 1 #

Patch Set 2 : diff -r c9adabc5fbdf https://code.google.com/p/plan9port #

Patch Set 3 : diff -r c9adabc5fbdf https://code.google.com/p/plan9port #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/libventi/server.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

11 years, 10 months ago (2012-07-14 13:45:31 UTC) #1

rsc

11 years, 9 months ago (2012-07-29 22:53:42 UTC) #3

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=2b81e796018d
***

libventi: fix segfault in vtgetreq

Don't call vtlog() when _vtqrecv() returns
nil on queue hangup, as reported on
http://bitbucket.org/rsc/plan9port/issue/102/

R=rsc
http://codereview.appspot.com/6373046

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages