Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88)

Issue 6370043: code review 6370043: goprotobuf: Update docs for getters. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by dsymonds
Modified:
11 years, 2 months ago
Reviewers:
r, zhuangsirui
CC:
r, golang-dev
Visibility:
Public.

Description

goprotobuf: Update docs for getters.

Patch Set 1 #

Patch Set 2 : diff -r 64bf60aa5180 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 64bf60aa5180 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 64bf60aa5180 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -17 lines) Patch
M README View 1 4 chunks +22 lines, -11 lines 0 comments Download
M proto/lib.go View 1 4 chunks +40 lines, -6 lines 0 comments Download

Messages

Total messages: 6
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
13 years, 5 months ago (2012-06-28 17:33:45 UTC) #1
r
LGTM
13 years, 5 months ago (2012-06-28 17:41:09 UTC) #2
dsymonds
*** Submitted as http://code.google.com/p/goprotobuf/source/detail?r=04d7cf5b3d6c *** goprotobuf: Update docs for getters. R=r CC=golang-dev http://codereview.appspot.com/6370043
13 years, 5 months ago (2012-06-28 17:42:02 UTC) #3
zhuangsirui_gmail.com
Hi there, I'm just a beginner for Golang. When I see the README, I saw: ...
11 years, 2 months ago (2014-09-03 15:07:19 UTC) #4
dsymonds
On 4 September 2014 01:07, <zhuangsirui@gmail.com> wrote: > Dose that means i'd better use `*test.Label` ...
11 years, 2 months ago (2014-09-04 01:52:18 UTC) #5
zhuangsirui_gmail.com
11 years, 2 months ago (2014-09-04 02:52:30 UTC) #6
Thank you very much. You are so kind!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b