Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(487)

Issue 6369043: code review 6369043: goprotobuf: Generate getters. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by dsymonds
Modified:
13 years, 5 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

goprotobuf: Generate getters.

Patch Set 1 #

Patch Set 2 : diff -r 03ff7ddd4a7e https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 03ff7ddd4a7e https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 03ff7ddd4a7e https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1692 lines, -373 lines) Patch
M protoc-gen-go/descriptor/descriptor.pb.go View 1 17 chunks +669 lines, -152 lines 0 comments Download
M protoc-gen-go/descriptor/descriptor.pb.golden View 1 9 chunks +687 lines, -152 lines 0 comments Download
M protoc-gen-go/generator/generator.go View 1 25 chunks +105 lines, -32 lines 0 comments Download
M protoc-gen-go/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M protoc-gen-go/plugin/plugin.pb.go View 1 1 chunk +47 lines, -14 lines 0 comments Download
M protoc-gen-go/plugin/plugin.pb.golden View 1 1 chunk +57 lines, -22 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go View 1 3 chunks +63 lines, -0 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go.golden View 1 3 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
13 years, 5 months ago (2012-06-28 17:13:05 UTC) #1
r
LGTM assuming lib and README changes are coming with documentation updates.
13 years, 5 months ago (2012-06-28 17:17:10 UTC) #2
dsymonds
On Thu, Jun 28, 2012 at 10:17 AM, <r@golang.org> wrote: > LGTM assuming lib and ...
13 years, 5 months ago (2012-06-28 17:21:27 UTC) #3
dsymonds
13 years, 5 months ago (2012-06-28 17:22:14 UTC) #4
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=64bf60aa5180 ***

goprotobuf: Generate getters.

R=r
CC=golang-dev
http://codereview.appspot.com/6369043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b