Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 6357049: code review 6357049: net/http: Fix a verb-tense mismatch and a typo in docum... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by aam
Modified:
12 years, 11 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

net/http: Fix a verb-tense mismatch and a typo in documentation.

Patch Set 1 #

Patch Set 2 : diff -r 9a929b2b7cf1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9a929b2b7cf1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/net/http/server.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
aam
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2012-06-28 22:14:16 UTC) #1
bradfitz
LGTM On Thu, Jun 28, 2012 at 3:14 PM, <mirtchovski@gmail.com> wrote: > Reviewers: bradfitz, > ...
12 years, 11 months ago (2012-06-28 22:18:16 UTC) #2
bradfitz
*** Submitted as http://code.google.com/p/go/source/detail?r=f8a77e2b7d0b *** net/http: Fix a verb-tense mismatch and a typo in documentation. ...
12 years, 11 months ago (2012-06-28 22:18:41 UTC) #3
bradfitz
LGTM On Thu, Jun 28, 2012 at 3:14 PM, <mirtchovski@gmail.com> wrote: > Reviewers: bradfitz, > ...
12 years, 11 months ago (2012-06-28 23:25:39 UTC) #4
bradfitz
LGTM On Thu, Jun 28, 2012 at 3:14 PM, <mirtchovski@gmail.com> wrote: > Reviewers: bradfitz, > ...
12 years, 11 months ago (2012-06-28 23:42:26 UTC) #5
bradfitz
12 years, 11 months ago (2012-06-29 00:02:44 UTC) #6
LGTM

On Thu, Jun 28, 2012 at 3:14 PM, <mirtchovski@gmail.com> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: Fix a verb-tense mismatch and a typo in documentation.
>
> Please review this at
http://codereview.appspot.com/**6357049/<http://codereview.appspot.com/6357049/>
>
> Affected files:
>  M src/pkg/net/http/server.go
>
>
> Index: src/pkg/net/http/server.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/server.go
> +++ b/src/pkg/net/http/server.go
> @@ -848,13 +848,13 @@
>  // patterns and calls the handler for the pattern that
>  // most closely matches the URL.
>  //
> -// Patterns named fixed, rooted paths, like "/favicon.ico",
> +// Patterns name fixed, rooted paths, like "/favicon.ico",
>  // or rooted subtrees, like "/images/" (note the trailing slash).
>  // Longer patterns take precedence over shorter ones, so that
>  // if there are handlers registered for both "/images/"
>  // and "/images/thumbnails/", the latter handler will be
>  // called for paths beginning "/images/thumbnails/" and the
> -// former will receiver requests for any other paths in the
> +// former will receive requests for any other paths in the
>  // "/images/" subtree.
>  //
>  // Patterns may optionally begin with a host name, restricting matches to
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b