Issue 6357048: Un-trifurcate GrTextContext

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6357048: Un-trifurcate GrTextContext (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by TomH

Modified:
11 years, 10 months ago

Reviewers:
bsalomon

CC:
robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This change reverses r3412 and subsequent changes that broke GrTextContext into 3 classes (GrTextContext, GrBatchedTextContext, and GrDefaultTextContext). Eliminates a few hundred lines of code, simplifies state management.

Patch Set 1 #

Patch Set 2 : Leaks some state out of gradtext into hairmodes #

Patch Set 3 : Seems to work; needs cleanup + more testing, perf tweaks #

Patch Set 4 : Ready for review #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+346 lines, -616 lines)			Patch
M	gyp/gpu.gyp	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	include/gpu/GrTextContext.h	View	1 2 3	1 chunk	+35 lines, -85 lines	0 comments	Download
M	include/gpu/SkGpuDevice.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	src/gpu/GrBatchedTextContext.h	View	1 2	1 chunk	+0 lines, -84 lines	0 comments	Download
D	src/gpu/GrBatchedTextContext.cpp	View	1 2	1 chunk	+0 lines, -102 lines	0 comments	Download
D	src/gpu/GrDefaultTextContext.h	View	1 2	1 chunk	+0 lines, -48 lines	0 comments	Download
D	src/gpu/GrDefaultTextContext.cpp	View	1 2	1 chunk	+0 lines, -267 lines	0 comments	Download
A	src/gpu/GrTextContext.cpp	View	1 2 3	1 chunk	+306 lines, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		9 chunks	+4 lines, -24 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Landed as r4411.

Expand All Messages | Collapse All Messages