Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3877)

Issue 6353063: SSE optimization for S32_D16_filter_DX (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Lei
Modified:
12 years, 3 months ago
Reviewers:
DerekS, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This optimization was done on Android Gingerbread platform for SoftWeg benchmark. The benefit can be measured by running following command on Android platform: skia_bench -config 565 -match bitmap_8888_scale_filter -forceFilter 1 -repeat 30 The result I got on Android platform was below: w/o this optimization routine: D/skia ( 1868): running bench [640 480] bitmap_8888_scale_filter D/skia ( 1868): 565: cmsecs = 286.50 w/ optimization: D/skia ( 1463): running bench [640 480] bitmap_8888_scale_filter D/skia ( 1463): 565: cmsecs = 186.80 The net gain is 34.80%.

Patch Set 1 #

Patch Set 2 : add the declaration of S32_D16_filter_DX in SkBitmapProcState.h #

Patch Set 3 : update the comments for the bench test case and debugging check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -1 line) Patch
bench/BitmapBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
src/core/SkBitmapProcState.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
src/opts/SkBitmapProcState_opts_SSE2.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
src/opts/SkBitmapProcState_opts_SSE2.cpp View 1 2 1 chunk +133 lines, -0 lines 0 comments Download
src/opts/opts_check_SSE2.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16
Lei
12 years, 4 months ago (2012-07-03 06:36:02 UTC) #1
reed1
Did not compile on my machine: /clean5/trunk/gyp/../src/opts/opts_check_SSE2.cpp: In member function 'void SkBitmapProcState::platformProcs()': /clean5/trunk/gyp/../src/opts/opts_check_SSE2.cpp:120: error: 'S32_D16_filter_DX' ...
12 years, 4 months ago (2012-07-03 12:15:29 UTC) #2
Lei
It's strange. I can build on Android build. The definition is located in section of ...
12 years, 4 months ago (2012-07-04 07:17:26 UTC) #3
Lei
Hi Reed, does the error still exist on your side?
12 years, 3 months ago (2012-07-16 07:24:06 UTC) #4
reed1
/clean5/trunk/gyp/../src/opts/opts_check_SSE2.cpp: In member function 'void SkBitmapProcState::platformProcs()': /clean5/trunk/gyp/../src/opts/opts_check_SSE2.cpp:120: error: 'S32_D16_filter_DX' was not declared in this scope
12 years, 3 months ago (2012-07-16 16:02:06 UTC) #5
reed1
I am building on a mac. Can you build cleanly there w/ and w/o your ...
12 years, 3 months ago (2012-07-16 16:02:48 UTC) #6
Lei
add the declaration of S32_D16_filter_DX in SkBitmapProcState.h
12 years, 3 months ago (2012-07-17 06:29:27 UTC) #7
Lei
On 2012/07/16 16:02:48, reed1 wrote: > I am building on a mac. Can you build ...
12 years, 3 months ago (2012-07-17 06:33:17 UTC) #8
reed1
Thanks, this builds for me now. What bench(s) should I run to see the performance ...
12 years, 3 months ago (2012-07-17 19:57:40 UTC) #9
Lei
Hi Reed, thanks for your effort. This has filter option. I will find the config ...
12 years, 3 months ago (2012-07-18 02:06:28 UTC) #10
Lei
update the comments for the bench test case and debugging check
12 years, 3 months ago (2012-07-24 07:42:09 UTC) #11
Lei
Hi Reed, I updated the performance gain in the description of this issue. Please help ...
12 years, 3 months ago (2012-07-24 08:23:45 UTC) #12
reed1
Derek, can you comment on android syncing?
12 years, 3 months ago (2012-07-24 13:21:52 UTC) #13
DerekS
On 2012/07/24 13:21:52, reed1 wrote: > Derek, can you comment on android syncing? Yes, I ...
12 years, 3 months ago (2012-07-24 13:42:33 UTC) #14
reed1
very good bench summary. landed in rev. 4729
12 years, 3 months ago (2012-07-24 13:53:42 UTC) #15
Lei
12 years, 3 months ago (2012-07-25 02:18:47 UTC) #16
Thanks, Reed and DerekS. I will close this issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b