Issue 6352097: code review 6352097: freetype/truetype: odd/even opcodes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6352097: code review 6352097: freetype/truetype: odd/even opcodes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by nigeltao

Modified:
11 years, 11 months ago

Reviewers:

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

freetype/truetype: odd/even opcodes. Also re-arrange some of the switch cases to be in opcode order.

Patch Set 1 #

Patch Set 2 : diff -r 6d4d289ee00e https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 6d4d289ee00e https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r 6d4d289ee00e https://code.google.com/p/freetype-go #

Patch Set 5 : diff -r 6d4d289ee00e https://code.google.com/p/freetype-go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -13 lines)			Patch
M	freetype/truetype/hint.go	View	1	2 chunks	+14 lines, -10 lines	0 comments	Download
M	freetype/truetype/hint_test.go	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	freetype/truetype/opcodes.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

11 years, 11 months ago (2012-07-11 12:57:01 UTC) #1

bsiegert

LGTM This 26.6 arithmetic is strange. Thanks for the explanatory comment in the tests.

11 years, 11 months ago (2012-07-11 13:53:19 UTC) #2

nigeltao

11 years, 11 months ago (2012-07-12 11:06:08 UTC) #3

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=c64c75ce4f62 ***

freetype/truetype: odd/even opcodes.

Also re-arrange some of the switch cases to be in opcode order.

R=bsiegert
CC=golang-dev
http://codereview.appspot.com/6352097

Expand All Messages | Collapse All Messages