Issue 6352079: code review 6352079: cmd/6g: fix float32/64->uint64 conversion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6352079: code review 6352079: cmd/6g: fix float32/64->uint64 conversion (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by minux1

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

cmd/6g: fix float32/64->uint64 conversion CVTSS2SQ's rounding mode is controlled by the RC field of MXCSR; as we specifically need truncate semantic, we should use CVTTSS2SQ. Fixes issue 3804.

Patch Set 2 : diff -r 100ddb84c85d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6751a0e1a6a4 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 87e3318f6a52 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 87e3318f6a52 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 87e3318f6a52 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 87e3318f6a52 https://code.google.com/p/go/ #

Patch Set 8 : diff -r 87e3318f6a52 https://code.google.com/p/go/ #

Patch Set 9 : diff -r 1f9e023245d4 https://code.google.com/p/go/ #

Patch Set 10 : diff -r 1f9e023245d4 https://code.google.com/p/go/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -2 lines)			Patch
	M	src/cmd/6g/gsubr.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	A	test/fixedbugs/bug447.go	View	1 2 3 4 5 6 7	1 chunk	+105 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 5 months ago (2012-07-26 04:24:00 UTC) #1

rsc

thanks for fixing this. http://codereview.appspot.com/6352079/diff/7001/test/fixedbugs/bug446.go File test/fixedbugs/bug446.go (right): http://codereview.appspot.com/6352079/diff/7001/test/fixedbugs/bug446.go#newcode29 test/fixedbugs/bug446.go:29: fmt.Fprintf(bout, "\t%s := %s(39.7)\n", fn, ...

13 years, 5 months ago (2012-07-30 01:53:49 UTC) #2

minux1

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2012-08-09 05:30:29 UTC) #3

minux1

13 years, 4 months ago (2012-08-23 06:35:38 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=5972fe3f4418 ***

cmd/6g: fix float32/64->uint64 conversion
    CVTSS2SQ's rounding mode is controlled by the RC field of MXCSR;
as we specifically need truncate semantic, we should use CVTTSS2SQ.

    Fixes issue 3804.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/6352079

Expand All Messages | Collapse All Messages